1780267 - [Colorway Closet] browser_html_list_view.js and browser_monochromatic_aboutaddons.js fail with browser.theme.colorway-closet = true

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Dão Gottwald [:dao]]

See https://treeherder.mozilla.org/jobs?repo=try&revision=27be0f983cb38e891cee519b3d8862d82e6cc487&selectedTaskRun=U7_zLRTvS4ey-bP5saDE_w.0:

TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_list_view.js | Empty addons message visible -
TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_monochromatic_aboutaddons.js | Uncaught exception in test - at chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_monochromatic_aboutaddons.js:42 - TypeError: can't access property "querySelector", colorwayList is null

Comment 1

[kpatenio]

The old colorways section (which browser_monochromatic_aboutaddons.js tests) relies on the colorway closet pref disabled in order to appear (searchfox). We could update the test to run the current test cases with the pref disabled, then add a new test case verifying the old section does not appear if the pref is enabled.

As for browser_html_list_view.js, the assertion that fails is when we check if the empty addons message is visible (searchfox). It only fails for themes because the colorway closet card remains on the page (if the pref is enabled); the assertion requires that all sections of the page are removed. Therefore we can just add the following to fix it in testEmptyMessage:

      let colorwaysSection = getSection(doc, `colorways-section`);
      colorwaysSection.remove();

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1780267 - [Colorway Closet] Make browser_html_list_view.js and browser_monochromatic_aboutaddons.js work with browser.theme.colorway-closet = true. r=rpl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70e6d4f14fc0
[Colorway Closet] Make browser_html_list_view.js and browser_monochromatic_aboutaddons.js work with browser.theme.colorway-closet = true. r=rpl

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/70e6d4f14fc0