Closed Bug 1780278 Opened 2 years ago Closed 2 years ago

Merge optimization logic between the two taskgraphs

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox105 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Note that this explicitly excludes the strategies themselves (unless they are shared, like index-search).

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77a4bc82a9c0
Update vendored taskgraph to 2.0.0, r=releng-reviewers,hneiva
https://hg.mozilla.org/integration/autoland/rev/609afc0ae2f6
Merge optimization logic between the two taskgraphs, r=releng-reviewers,gabriel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/cbe24d0a60e3
Port bug 1780278 - Merge optimization logic between the two taskgraphs. rs=bustage-fix

Backed out for breaking manual action tasks to add or backfill new tasks.

Backout link: https://hg.mozilla.org/mozilla-central/rev/3aacd5e03f7f3fac1a4ac2c53a4e5d547c9aa205

Status: RESOLVED → REOPENED
Flags: needinfo?(ahal)
Resolution: FIXED → ---
Target Milestone: 105 Branch → ---
Backout by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/354c124a7052
Backed out changeset cbe24d0a60e3 since the mozilla-central part was backed out. rs=backout DONTBUILD

Looks like it broke because we were no longer importing gecko_taskgraph.optimize from the context of actions and therefore the custom Gecko optimization strategies were not being registered. The latest revision on phabricator should contain a fix (though I was unable to reproduce the bug locally).

Flags: needinfo?(ahal)

I'm not sure if all backfill-task actions were broken or not, but I was able to run one on by try push:
https://treeherder.mozilla.org/jobs?repo=try&revision=40b5224ada7045dd6390ea6a4c1ebf167a155700&selectedTaskRun=a0up4FpVSJesKX5rsIv0_Q.0

So going to try re-landing.

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef99c9c3a0f6
Update vendored taskgraph to 2.0.0, r=releng-reviewers,hneiva
https://hg.mozilla.org/integration/autoland/rev/1fc676162294
Merge optimization logic between the two taskgraphs, r=releng-reviewers,gabriel
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2963a87715a1
Port bug 1780278 - Merge optimization logic between the two taskgraphs. rs=bustage-fix
See Also: → 1853894
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: