1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We've converted various modules across to .sys.mjs but the scripts missed switching ChromeUtils.importESModule for XPCOMUtils to use standard import syntax.

The script issue is being fixed in bug 1780301, this is a follow-up to do these conversions for the files I've already migrated.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r?arai

Depends on D152114

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee4c4d34816c
Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai

Comment 3

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for node newtab
Failure log for failed TV job on test_permmanager_migrate_7-8.js
Failure log for failed TV job on browser_newtab_trigger.js
Failure log for failed TV job on browser_default_bookmark_toolbar_visibility.js
Failure log for failed TV job on browser_all_files_referenced.js
Failure log for failed TV job on browser_ext_urlbar.js

Failure log for failed node newtab job on the backout push

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f22c0f99cf1
Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing doc generate failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ccddb3f54bb2856112ddc411d85cd709393a8bbe

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c3a9142535
Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser/base/content/test/performance/browser_preferences_usage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb8ad931122559e1523cc7e53ae581f7886e3a19

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eef25b87559
Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6eef25b87559