1780348 - Crash in [@ mozilla::FullscreenRequest::CreateForRemote]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Not a new crash signature. 60-150 crash reports per release cycle.

Crash report: https://crash-stats.mozilla.org/report/index/75771904-d535-4e2a-b88a-9b7dd0220718

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll static mozilla::FullscreenRequest::CreateForRemote dom/base/FullscreenChange.h:89
1 xul.dll mozilla::dom::Document::RemoteFrameFullscreenChanged dom/base/Document.cpp:14910
2 xul.dll nsDOMWindowUtils::RemoteFrameFullscreenChanged dom/base/nsDOMWindowUtils.cpp:3585
3 xul.dll XPTC__InvokebyIndex 
4 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1125
5 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:963
6 xul.dll Interpret js/src/vm/Interpreter.cpp:3325
7 xul.dll js::Call js/src/vm/Interpreter.cpp:606
8 xul.dll JS::Call js/src/vm/CallAndConstruct.cpp:117
9 xul.dll mozilla::dom::MessageListener::ReceiveMessage dom/bindings/MessageManagerBinding.cpp:6083

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think this is coming from https://searchfox.org/mozilla-central/rev/c11f54459452dd2f9ab2f9bec4ae03127897d256/browser/actors/DOMFullscreenChild.jsm#27
We have null remoteFrame there?

Comment 2

[Edgar Chen [:edgar]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #1)

We have null remoteFrame there?

Yea, I found a way to reproduce the crash, it happens when page are in the middle of fullscreen transition, and navigates away.
I think in this case we should just stop process fullscreen request and clean up the state.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1780348 - Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition;

Comment 4

[Edgar Chen [:edgar]]

Attachment: test.html

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8740f45621e
Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition; r=smaug

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8740f45621e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:edgar, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Edgar Chen [:edgar]]

Comment on attachment 9288565 [details]
Bug 1780348 - Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition;

Beta/Release Uplift Approval Request

• User impact if declined: Tab might crash when process fullscreen request.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes only affects when embedderElement is null.
• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9288565 [details]
Bug 1780348 - Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition;

Approved for 104.0b9

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ae4808c071f5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 12

[Edgar Chen [:edgar]]

Comment on attachment 9288565 [details]
Bug 1780348 - Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition;

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This fixes a crash happens when page navigates away in the middle of process of fullscreen request.
• User impact if declined: Tab might crash when page navigates away in the middle of process of fullscreen request.
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes only affects when embedderElement is null.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288565 [details]
Bug 1780348 - Exit fullscreen if DOMFullscreenChild is not able to continue the fullscreen transition;

Approved for 102.3esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/4894228dde3b