1780442 - [wpt-sync] Sync PR 34919 - Navigation API: Revamp intercepted-navigation scroll handling

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34919
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Navigation API: Revamp intercepted-navigation scroll handling

Follows https://github.com/WICG/navigation-api/pull/239

Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/DKeklNbLG5s

Bug: 1345507
Change-Id: Id5c1b9d77953388dbe287f6403b0a49c8359d51b

Reviewed-on: https://chromium-review.googlesource.com/3758902
WPT-Export-Revision: 912f23a7c139596e43bfe897bf3c63eee278197e

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 34919 applied with additional changes from upstream: 5f0779f40dbb30349778db64db04754df8c4a4ef

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8536a7aaea43c4c4d78438baedfb1b49088c4c7a

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3513787f70c59888106e316e45250eff465e4264

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 20 tests and 1 subtests

Status Summary

Firefox

OK : 20
FAIL : 20

Chrome

OK : 6
PASS : 2
FAIL : 16
ERROR: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /navigation-api/scroll-behavior/after-transition-basic.html [wpt.fyi]
  • scroll: after-transition should scroll when back completes: FAIL (Chrome: PASS)
• /navigation-api/scroll-behavior/after-transition-change-history-scroll-restoration-during-promise.html [wpt.fyi]
  • scroll: after-transition should ignore history.scrollRestoration even if it changes in the middle of the navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-explicit-scroll.html [wpt.fyi]
  • scroll: scroll() should preempt after-transition: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-intercept-handler-modifies.html [wpt.fyi]
  • scroll: state should be saved before intercept handlers run: FAIL
• /navigation-api/scroll-behavior/after-transition-push.html [wpt.fyi]
  • scroll: after-transition should work on a push navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-reject.html [wpt.fyi]
  • scroll: after-transition should not scroll when the intercept() handler rejects: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-reload.html [wpt.fyi]
  • scroll: after-transition should work on a reload navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-replace.html [wpt.fyi]
  • scroll: after-transition should work on a replace navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/after-transition-timing.html [wpt.fyi]
  • scroll: after-transition should scroll when back completes, just before navigatesuccess: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-basic.html [wpt.fyi]
  • scroll: manual should prevent auto scroll on back.: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-immediate-scroll.html [wpt.fyi]
  • scroll: scroll() should work inside a navigate event handler: FAIL (Chrome: PASS)
• /navigation-api/scroll-behavior/manual-scroll-after-dispatch.html [wpt.fyi]
  • scroll: scroll() should work after a navigate event dispatch: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-after-resolve.html [wpt.fyi]
  • scroll: scroll() should throw after a navigation finished promise fulfills: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-fragment-does-not-exist.html [wpt.fyi]
  • scroll: scroll() should do nothing when the fragment does not exist: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-push.html [wpt.fyi]
  • scroll: scroll() should work on a push navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-reload.html [wpt.fyi]
  • scroll: scroll() should work on a reload navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-repeated.html [wpt.fyi]
  • scroll: scroll() should throw if called a second time: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-replace.html [wpt.fyi]
  • scroll: scroll() should work on a replace navigation: FAIL (Chrome: FAIL)
• /navigation-api/scroll-behavior/manual-scroll-resets-when-no-fragment.html [wpt.fyi]
  • scroll: scroll() should reset scroll position when the destination url contains no fragment: FAIL
• /navigation-api/scroll-behavior/scroll-without-intercept.html [wpt.fyi]
  • scroll: scroll() should throw for non-intercept: FAIL (Chrome: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819128a2e742
[wpt PR 34919] - Navigation API: Revamp intercepted-navigation scroll handling, a=testonly
https://hg.mozilla.org/integration/autoland/rev/db07b0208324
[wpt PR 34919] - Update wpt metadata, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/819128a2e742
https://hg.mozilla.org/mozilla-central/rev/db07b0208324