Closed Bug 1780449 Opened 2 years ago Closed 2 years ago

If mercurial is not installed mach will not recognize your source folder as a hg checkout

Categories

(Firefox Build System :: Mach Core, defect)

defect

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: smurfd, Assigned: smurfd)

Details

Attachments

(1 file)

Steps to reproduce :
remove hg from path
run ./mach bootstrap it should now end something like :

Please choose the version of Firefox you want to build (see note above):
  1. Firefox for Desktop Artifact Mode [default]
  2. Firefox for Desktop
  3. GeckoView/Firefox for Android Artifact Mode
  4. GeckoView/Firefox for Android
  5. SpiderMonkey JavaScript engine
Your choice: 1
Error running mach:

    ['bootstrap']

This is a user error and does not appear to be a bug in mach.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

mach.util.UserError: Could not identify the root directory of your checkout! Are you running `mach bootstrap` in an hg or git clone?

  File "/home/rumrogers/Code/Mozilla/mc/python/mozboot/mozboot/mach_commands.py", line 43, in bootstrap
    bootstrapper.bootstrap(command_context.settings)
  File "/home/rumrogers/Code/Mozilla/mc/python/mozboot/mozboot/bootstrap.py", line 331, in bootstrap
    (checkout_type, checkout_root) = current_firefox_checkout(
  File "/home/rumrogers/Code/Mozilla/mc/python/mozboot/mozboot/bootstrap.py", line 622, in current_firefox_checkout
    raise UserError(

Its because this :
https://searchfox.org/mozilla-central/rev/ffb50da3ca89100b6ae5054cfe69c187679515f0/python/mozboot/mozboot/bootstrap.py#327
would probably be better if done after ensuring mercurial exist
https://searchfox.org/mozilla-central/rev/ffb50da3ca89100b6ae5054cfe69c187679515f0/python/mozboot/mozboot/bootstrap.py#349

with this patch ill upload shortly it will say this :

Please choose the version of Firefox you want to build (see note above):
  1. Firefox for Desktop Artifact Mode [default]
  2. Firefox for Desktop
  3. GeckoView/Firefox for Android Artifact Mode
  4. GeckoView/Firefox for Android
  5. SpiderMonkey JavaScript engine
Your choice: 2

Could not find Mercurial (hg) in the current shell's path. Try starting a new
shell and running the bootstrapper again.

then try to install/upgrade it later down ...

Assignee: nobody → smurfd
Status: NEW → ASSIGNED
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/0eac7d8af5be
If mercurial is not installed mach will not recognize your source folder as a hg checkout r=firefox-build-system-reviewers,ahochheiden
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

You get error "Could not identify the root directory of your checkout! Are you running mach bootstrap in an hg or git clone?" if you download a zipped source (for example http://ftp.mozilla.org/pub/firefox/releases/106.0/source/firefox-106.0.source.tar.xz), unpack it and then try to run ./mach bootstrap. Clearly that is neither an hg of git clone. Is ./mach bootstrap meant to work in this situation or do people need to create their own build environment? We're asking since FlatPak uses zipped source, but they have their own build machines which are configured with node, llvm and rust.

Flags: needinfo?(smurfd)

Hey b5, thanks for the feedback.
filed a followup bug : https://bugzilla.mozilla.org/show_bug.cgi?id=1798746
thinking it should be a somewhat easy fix.

Flags: needinfo?(smurfd)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: