Closed Bug 1780554 Opened 2 years ago Closed 2 years ago

Remote Settings fetching broken in PersonalityProvider.jsm

Categories

(Firefox :: Pocket, defect)

Product:
Firefox
Component:
Pocket
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- verified
firefox102 --- wontfix
firefox103 --- verified
firefox104 --- verified
firefox105 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr102+
Details | Review
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-release+
Details | Review

Looks like this should be called with lazy.Utils.SERVER_URL now instead.

:leplatrem, since you are the author of the regressor, bug 1702759, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mathieu)
Assignee: nobody → sdowne

I think I have a fix incoming already.

Depends on: 1780445
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/aded6ac77068
Fix Remote settings server url in PersonalityProvider.jsm r=barret

https://hg.mozilla.org/mozilla-central/rev/aded6ac77068

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

What's the end user impact of this bug? Is this something we should consider backporting to ESR102?

Flags: needinfo?(sdowne)
Flags: in-testsuite+

Probably not worth putting into ESR102.

The impact is marginal short to mid term, as it doesn't visibly show an error to the user, just the content might be sorted differently for certain users.

And for what it's worth, I wouldn't have pushed to uplift it had I had the opportunity to do so.

Flags: needinfo?(sdowne)

Comment on attachment 9286459 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

Beta/Release Uplift Approval Request

  • User impact if declined: Potentially impacting content personalization and the content quality the user sees, which can also have impact to revenue.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Just regression testing that we didn't break something else.

Ensure Pocket newtab stories and spocs are still displaying on a fresh profile.

  1. Ensure you are in a locale and region that's eligible for Pocket stories on newtab and spocs, example en-US.
  2. Open a newtab with a new profile.

Expected: should see pocket content and sponsored content.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The changes are quite small.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9286459 - Flags: approval-mozilla-release?
Flags: qe-verify+

Comment on attachment 9287552 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Potential fix to user experience and revenue.
  • User impact if declined: Potentially impacting content personalization and the content quality the user sees, which can also have impact to revenue.
  • Fix Landed on Version: 104
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 1 line fix
Attachment #9287552 - Flags: approval-mozilla-esr102?
QA Whiteboard: [qa-triaged]

I‘ve verified this issue using the latest Firefox Nightly 105.0a1 (Build ID: 20220728215301) and Firefox Beta 104.0b3 (Build ID: 20220728185815) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.10 x64.

  • The Pocket and Sponsored cards are correctly displayed on new tab.
  • The related pages successfully load when the stories/spocs are clicked.
Status: RESOLVED → VERIFIED
status-firefox104: fixed → verified
status-firefox105: --- → verified

Comment on attachment 9286459 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

Approved for 103.0.1, thanks.

Attachment #9286459 - Flags: approval-mozilla-release? → approval-mozilla-release+

Backed out from release for causing lint failures on PersonalityProvider.jsm

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/newtab/lib/PersonalityProvider/PersonalityProvider.jsm:26:9 | 'Services' is assigned a value but never used. (no-unused-vars)
status-firefox103: fixed → affected
Flags: needinfo?(sdowne)

Looking into it

I had to make a new pull request, 2 tiny changes:

  1. Small fix to a test that would also have been fixed with 1780445 but instead I fixed to be independent to keep things simply for the point release.
  2. and fixing a unused Services variable that was removed between 103 and 104 in 1667455.

Comment on attachment 9287806 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

Beta/Release Uplift Approval Request

  • User impact if declined: Potentially impacting content personalization and the content quality the user sees, which can also have impact to revenue.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Regression testing that we didn't break something else.

Ensure Pocket newtab stories and spocs are still displaying on a fresh profile.

1. Ensure you are in a locale and region that's eligible for Pocket stories on newtab and spocs, example en-US.
2. Open a newtab with a new profile.

Expected: should see pocket content and sponsored content.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The changes are quite small.
  • String changes made/needed: None
  • Is Android affected?: No
Flags: needinfo?(sdowne)
Attachment #9287806 - Flags: approval-mozilla-release?
See Also: → 1782355
Attachment #9286459 - Flags: approval-mozilla-release+

Comment on attachment 9287552 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

Approved for 102.2esr.

Attachment #9287552 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+

Comment on attachment 9287806 [details]
Bug 1780554 - Fix Remote settings server url in PersonalityProvider.jsm

Approved for 103.0.2, thanks.

Attachment #9287806 - Flags: approval-mozilla-release? → approval-mozilla-release+

I‘ve verified this issue using Firefox Release 103.0.2 (Build ID: 20220808125904) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.3 x64.

  • The Pocket and Sponsored cards are correctly displayed on new tab.
  • The related pages are successfully loaded when the stories/spocs are clicked.
status-firefox103: fixed → verified
Attachment #9286459 - Attachment is obsolete: true

I‘ve verified this issue using Firefox 102.2.0esr (Build ID: 20220815170108) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.3 x64.

  • The Pocket and Sponsored cards are correctly displayed on new tab.
  • The related pages are successfully loaded when the stories/spocs are clicked.
status-firefox-esr102: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: