1780576 - Clean up in test_ext_userScripts_register.js on failure

Status: RESOLVED FIXED

(WebExtensions :: General, task)

Description

[Andrew McCreight [:mccr8]]

The "equal" function in XPCShell tests apparently throws immediately on failure, which means that if it fails you get a lot of unrelated failures in this test because it then doesn't clean up after itself. I patched this by using registerCleanupFunction, and by waiting to call equal until contentPage is closed.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1780576 - Clean up test_ext_userScripts_register.js on failure.

equal throws immediately, so if it fails you get some follow-on
failures because the test didn't clean up that make it confusing
to figure out what actually failed. This patch fixes that by using
registerCleanupFunction to remove the extension, and waits to
do the check until after contentPage has been closed.

Comment 2

[Andrew McCreight [:mccr8]]

I confirmed that there are no additional failures when this test fails with my patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/951002217e9f
Clean up test_ext_userScripts_register.js on failure. r=extension-reviewers,mixedpuppy

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/951002217e9f