1780586 - Crash in [@ mozilla::layers::IsCGColorOpaqueBlack]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/641b2e77-82df-4b65-b7ad-387a30220721

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL mozilla::layers::IsCGColorOpaqueBlack gfx/layers/NativeLayerCA.mm:503
1 XUL mozilla::layers::NativeLayerRootCA::CommitToScreen gfx/layers/NativeLayerCA.mm:317
2 XUL mozilla::wr::RenderCompositorNative::CompositorEndFrame gfx/webrender_bindings/RenderCompositorNative.cpp:267
3 XUL webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer/mod.rs:2198
4 XUL webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer/mod.rs:1737
5 XUL wr_renderer_render gfx/webrender_bindings/src/bindings.rs:620
6 XUL mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:560
7 XUL mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:410
8 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1200
9 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1199

I hit this crash while watching a video on Twitter. I think I had been watching the video in full screen, and I exited full screen when it crashed. I'll see if it happens with another video or I can find the same video again.

Comment 1

[Andrew McCreight [:mccr8]]

It looks like the line we're crashing on was added in bug 1737682. I'll assume this is a regression from that for now.

Comment 2

[Andrew McCreight [:mccr8]]

Looks like there are more people experiencing this crash. I tried messing around with some other videos on Twitter and I couldn't reproduce the issue. I also couldn't find the specific video I was watching before thanks to the feed algorithm I guess.

Comment 3

[Brad Werth [:bradwerth] | Out until March 3]

Replication will be tricky because it relies upon the timing of the video telemetry. Seems like this could arise if CGColorGetNumberOfComponents returns 0, which it might do if the color is kCGColorClear. I'll upload a patch.

Comment 4

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1780586: Make IsCGColorOpaqueBlack handle clear color correctly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98460b4d7285
Make IsCGColorOpaqueBlack handle clear color correctly. r=gfx-reviewers,jrmuizel

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/98460b4d7285