1780658 - folderCompactStart() is not invoked for non-local folders - gloda implications

Status: NEW

(MailNews Core :: Backend, task)

Description

[Ben Campbell]

According to the comments in the IDL and also from a cursory scanning of the folderCompactor code, the folder notification service isn't told to send out a notification when compaction begins on non-local folders.

Here's the IDL file comment:
https://searchfox.org/comm-central/source/mailnews/base/public/nsIMsgFolderListener.idl#197

Here's where the FolderCompactStart notification is sent out for local folders:
https://searchfox.org/comm-central/source/mailnews/base/src/nsMsgFolderCompactor.cpp#464

But I don't think it's called by nsOfflineStoreCompactState, which is what compacts non-local folders.

I think the Gloda might be the main place which would be affected:
https://searchfox.org/comm-central/search?q=folderCompactStart&path=IndexMsg.jsm&case=true&regexp=false

Maybe there's a good reason for gloda to handle local compaction differently to IMAP (offline-storage) compactions, but if the current behaviour is intended, it seems that it should be gloda making the "I'll do nothing" decision, not the compaction code.

investigation required.