178077 - switching tabs with keyboard shouldn't put dotted focus line around page

Status: RESOLVED WORKSFORME

(SeaMonkey :: Tabbed Browser, enhancement)

Description

[Matthew Miller]

When one uses the keyboard (ctrl-tab or ctrl-pgup/down) to switch tabs, the
entire page gets an "i'm focused" indicator. This is ugly -- I just want to
switch tabs quickly, not select anything.

Comment 1

[R.K.Aa.]

Please always indicate OS and build ID in bug-reports.
Ctrl+tab will shift desktop on Linux. Ctrl+pgup/down WFM, day old CVS, Linux: No
dotted focus around the page.

Comment 2

[Sander]

confirming, win98, 2002110208. This has been mildly bugging me for a while now.
Manually switching tabs doesn't do anything like this, but switching between
tabs through a keyboard shortcut gets that dotted focus. (I figure adding a
window.blur() would fix it...)

Comment 3

[Matthew Miller]

R.K.Aa -- ctrl-tab does not necessarily shift desktop on Linux -- that is a
window manager-specific thing. In my case, it does indeed get passed to mozilla
and works fine -- but, like ctrl-pgup/down, it exhibits the exact same selection
behavior. 

This is with the 1.2b release; haven't tried it with a nightly on Linux yet, but
nightly on Win98 definitely has identical behavior.

Comment 4

[Boris Zbarsky [:bzbarsky]]

If we don't focus the body, then when you try to scroll with keyboard, the body
won't scroll.  So we should be focusing it.  In fact, I think the bug is in the
mouse-only switching -- we should always show the focus outline...

Comment 5

[Sander]

Keyboard scrolling works fine after switching tabs with the mouse. The focus
still is on the page, there's just no annoying visual indicator of this fact.

Comment 6

[Matthew Miller]

Confirmed that this bug happens on newer Linux builds -- 2002110404, just as it
did on older ones (2002031209, for example). I didn't set OS to "All" by
accident; it is, in fact, a cross-platform bug.

Comment 7

[Jesse Ruderman]

Aaron, do you know why switching tabs with Ctrl+Tab puts a dotted focus outline
around the content area while switching tabs with the mouse doesn't?

See also bug 120148, "Tabs don't remember which element was focused when
switching tabs".

Comment 8

[Aaron Leventhal]

Jesse, it's something I'm trying to fix in bug 175893.

Comment 9

[Jesse Ruderman]

WFM in Firebird and Seamonkey.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040128
Firebird/0.8.0+

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040125