178078 - [cust] Toolbar customization dialog doesn't always fit on screen

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Joonas]

Tested with Windows 98 and Linux (GNOME2/metacity and IceWM).

Under some circumstances, the toolbar customization dialog rolls outside the 
visible desktop area. It's pretty easy to lose the "Done" button outside the 
visible area if you're not careful. If "Done" disappears, it's very hard to 
close the dialog (the workaround is to press shift-tab and then space).

Having a screen resolution like 800x600 or 640x480 makes things even more 
tricky, since the customization dialog is huge (600x400 pixels or so).

Steps to reproduce:

1) move the Phoenix window near the bottom of the screen (so that there isn't 
enough vertical space under the toolbars for the dialog to appear)
2) View/Toolbar/Customize...

or:

1) move the window to the right edge of the screen so that half of it is outside
the visible area
2) View/Toolbar/Customize...

What happens: the dialog rolls outside the screen. Very difficult to close the 
dialog (workaround: press shift-tab, then space)

Expected: should be able to edit the toolbars.

Comment 1

[Joonas]

Should the dialog roll up instead of down or to the right/left if it won't fit 
otherwise? What if there isn't enough room anyway? Should the parent window 
automatically move to a better place?

What does OSX do if a sheet won't fit on screen?

(note that moving the window to unhide the Done button doesn't work: you can
move the window but the dialog doesn't move, see bug 178079)

Comment 2

[Asa Dotzler [:asa]]

This would be alleviated significantly once have ESC or some other command
hooked up to exit the customize dialog. That's already reported somewhere.

Comment 3

[Chu Alan "sprite"]

Attachment: customize dialog patch, part 1 of 3

there are three patches concerning customize dialog in total.
(bug 178078, bug 171454, bug 171106)

Comment 4

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 5

[Michael Wolf]

The bug is still existing in Mozilla Firebird 0.6.1. It should be fixed because
it is important for localization. Some languages use longer words than English
does. Dialog boxes should be resizable. On the whole, Firebird should more
consider the interests of localization if it shall replace Mozilla.

Comment 6

[J.B. Nicholson]

Attachment: Toolbar customization panel with scrollbars.

Toolbar customization panel is too small and hard to use.

Comment 7

[J.B. Nicholson]

The toolbar panel would fit on my screen but Firefox doesn't make it wide enough
or tall enough to be able to see all the icons, labels, and buttons (see
attachment "Toolbar customization panel with scrollbars.").  How about doing it
the way Epiphany does it -- use a regular window with automatic formatting to
handle large window sizes (more space than is needed results in even spacing of
icons/labels) and small window sizes (less space than needed results in adding
scroll bars).  I know this isn't as animated as Firefox is going for, but it
works.  The animation Epiphany uses to insert toolbar objects works well too.

Comment 8

[Simon Bünzli]

Attachment: Make sure the dialog is always fully visible

I suppose it's already pretty late for this bug to be alleviated somewhat more.
Anyway, this simple patch makes sure that the customize dialog remains always
fully visisble on screen (otherwise it'll jump back to it's half-visible
position anytime you drop a button). This is done by aligning it to the side
borders should it overlap and by moving it above the toolbars should there not
be enough space below.

Some more things which might be fixed in the course of this bug or a new bug
(tell me if you want them reported/done):
* Don't assume that screen.availLeft == 0 (might not be the case on
multi-screen systems).
* Don't move/resize the dialog unless it's actually overlapping a toolbar (the
user might have moved/resized it intentionally, see also bug 264489 for
persistent size changes).

Comment 9

[emm.sii]

Attachment: screenshot from Firefox "Customize Toolbar"

Firefox may not allow display "View in IE" extensions icon-mess

Comment 10

[Phil Ringnalda (:philor)]

Current trunk, Linux and Windows, the dialog is positioned onscreen, and Mac, the sheet moves with the window, so the only way you could get in trouble would be to have a Mac with a screen smaller than the sheet-like-thing, which wouldn't be this bug anyway.

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 197281 [details] [diff] [review]
Make sure the dialog is always fully visible

Clearing obsolete review request.

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 118194 [details] [diff] [review]
customize dialog patch, part 1 of 3

And, extremely obsolete review request, too.