178079 - [cust] Window can be moved when toolbar customization dialog active; dialog doesn't move

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Joonas]

Tested with Windows 98 and Linux (GNOME2/metacity and IceWM)

Steps to reproduce:

1) View/Toolbar/Customize...
2) Move the parent window

What happens: the window moves but the dialog doesn't

Expected: window shouldn't move, or the dialog should move with it

I guess the customization dialog should block the parent window so that it can't
be moved. Normal dialogs do this, are sheets special? What does OSX do?

Comment 1

[Joonas]

The only situation I can think of where moving the window would be useful is when 
the customization dialog doesn't fit on the screen, but that shouldn't happen 
(bug 178078).

Comment 2

[djk]

I have a patch which correctly positions the customize sheet when the main
window is resized.

I haven't yet been able to implement a similar behavior for window moving,
because of bug 66733.

I'll try to find another way to let the customize sheet know that the opener
window moved...

Comment 3

[djk]

Attachment: reposition customize sheet when opener window is resized or moved

Watching for resize events on the opener of the customize sheet along with use
of set/clearInterval for watching for moves seems to do the trick.

Comment 4

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 5

[Simon Paquet [:sipaq]]

*** Bug 223429 has been marked as a duplicate of this bug. ***

Comment 6

[Simon Paquet [:sipaq]]

*** Bug 233478 has been marked as a duplicate of this bug. ***

Comment 7

[Jon Henry]

djk, are you still watching this bug? You might try pinging
[e-mail] or [e-mail] for a review, Hyatt hasn't been
active on Firefox in a long time...

Comment 8

[Asa Dotzler [:asa]]

This would be good to get, though we could just make the sheet a dialog and
remove this and several other problems. 

Comment 9

[Matt Chaput]

In OS X, sheets automatically stay with their parent window.

I think this problem would be solved by not trying to duplicate the look of
sheets when sheets are not available (or available but not used on OS X!). It's
a somewhat **** imitation as it is.

Comment 10

[Simon Paquet [:sipaq]]

Blake, can you please look at this?

Comment 11

[chris hofmann]

unlikely that there will be time for this to be reviewed and make 1.0.  if
review happens renominate

Comment 12

[Mike Connor [:mconnor]]

The customize palette is now a window, this is no longer valid.