1780792 - Various WebGPU buffer code cleanups

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task)

Description

[Nicolas Silva [:nical]]

A collection of simple cleanup changes that came up during the work on bug 1777535 and its review.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Move the buffer creation code in Buffer.cpp. r=jimb

No funcitonal change here, I like to have the code maintaining and depending on the same invariants to be in the same place.

Depends on D151616

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Remove Buffer::Mappable(). r=jimb

It is not used anywhere.

Depends on D151629

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - use Buffer::GetDevice instead of mParent. r=jimb

Another cosmetic change. I've dabbled with IPDL actors too much to not think about WebGPUParent when reading "mParent". Also the parent-child relationship between Device and Buffer is not very obvious to me (nor is it part of the specification).
So I find that wrapping mParent in a GetDevice method to make the code easier to understand. It also makes it explicit that the parent pointer cannot be null.

Depends on D151630

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Move the remaining buffer logic in Device.cpp into Buffer.cpp. r=jimb

Having the code in the same place makes it easier to follow. This made me realize that the validation of aMode in mapAsync has to move to the device side (fix coming in a followup).

Depends on D151631

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Remove the public/private/public sandwich in Buffer.h. r=jimb

Depends on D152082

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Rename a variable to make the destination of the memcpy more explicit. r=jimb

Depends on D152093

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1780792 - Remove unnecessary MapRequest constructor. r=jimb

Depends on D152520

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c512a0c05a9
Move the buffer creation code in Buffer.cpp. r=jimb
https://hg.mozilla.org/integration/autoland/rev/6178c6dd5c31
Remove Buffer::Mappable(). r=jimb
https://hg.mozilla.org/integration/autoland/rev/326511661875
use Buffer::GetDevice instead of mParent. r=jimb
https://hg.mozilla.org/integration/autoland/rev/b4210142bf82
Move the remaining buffer logic in Device.cpp into Buffer.cpp. r=jimb
https://hg.mozilla.org/integration/autoland/rev/6de84921e7d0
Remove the public/private/public sandwich in Buffer.h. r=jimb
https://hg.mozilla.org/integration/autoland/rev/84974dbb4d3f
Remove unnecessary MapRequest constructor. r=jimb

Comment 9

[Marian-Vasile Laza]

Backed out 22 changesets (Bug 1780792, Bug 1778713, Bug 1771254, Bug 1777535) for causing bustages on WebGPUParent.h.
Backout link
Push with failures <--> BP-hybrid
Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e8821dd4f03
Move the buffer creation code in Buffer.cpp. r=jimb
https://hg.mozilla.org/integration/autoland/rev/e2c974f3d477
Remove Buffer::Mappable(). r=jimb
https://hg.mozilla.org/integration/autoland/rev/f611bfcfc02d
use Buffer::GetDevice instead of mParent. r=jimb
https://hg.mozilla.org/integration/autoland/rev/0204fff6c608
Move the remaining buffer logic in Device.cpp into Buffer.cpp. r=jimb
https://hg.mozilla.org/integration/autoland/rev/6607756956f2
Remove the public/private/public sandwich in Buffer.h. r=jimb
https://hg.mozilla.org/integration/autoland/rev/71079d2d9b1d
Remove unnecessary MapRequest constructor. r=jimb

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7e8821dd4f03
https://hg.mozilla.org/mozilla-central/rev/e2c974f3d477
https://hg.mozilla.org/mozilla-central/rev/f611bfcfc02d
https://hg.mozilla.org/mozilla-central/rev/0204fff6c608
https://hg.mozilla.org/mozilla-central/rev/6607756956f2
https://hg.mozilla.org/mozilla-central/rev/71079d2d9b1d