Closed
Bug 1780832
Opened 2 years ago
Closed 2 years ago
Pocket newtab collections and recent saves conflict
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
If a collection card grid is displayed, and recent saves is on, we end up with a recent saves in the collection grid AND the regular grid.
This is because collection card grid uses the generic card grid with some modified props, but recent saves prop was built into the base card grid.
This should instead be a prop passed to the card grid of choice inside discoverty stream base.
Probably not a huge issue because I don't see us using collection card grid any time soon, but should be fixed. It is an easy fix, and while collection card grid exists in code, it should be left in a not broken state.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/25e4cbaaa04b Pocket newtab fixing collection and recent saves grid conflict. r=gvn
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•