1780854 - Update opus to new version 378b4e5fc31b63c1f1a9f6a87a62609c5a083724 from 2022-07-22 12:22:47

Status: RESOLVED DUPLICATE of bug 1780967

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 4 commits:

---

378b4e5fc31b63c1f1a9f6a87a62609c5a083724 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opuscommit/378b4e5fc31b63c1f1a9f6a87a62609c5a083724
Authored: 2022-07-22 02:53:39 -0400
Committed: 2022-07-22 12:22:47 -0400

Ensuring we can see where crashes occur

Reviewed by Mark Harris

Files Modified:

• tests/test_opus_encode.c

---

4c6bae5078be71b0a4d69d0c3fa77a5a849f9876 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opuscommit/4c6bae5078be71b0a4d69d0c3fa77a5a849f9876
Authored: 2022-07-22 02:32:04 -0400
Committed: 2022-07-22 12:22:41 -0400

More ubsan fixes for the debug macros themselves

Reviewed by Mark Harris

Files Modified:

• silk/MacroDebug.h

---

e05aea9785f709f5aebb696ee5b4460681676e10 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opuscommit/e05aea9785f709f5aebb696ee5b4460681676e10
Authored: 2022-07-22 02:29:05 -0400
Committed: 2022-07-22 12:22:34 -0400

Using saturating round to fix some wrap-arounds

Reviewed by Mark Harris

Files Modified:

• celt/celt_decoder.c
• celt/celt_lpc.c

---

fbed746cb2d0fee57eae090e67d148d89923f6ff by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opuscommit/fbed746cb2d0fee57eae090e67d148d89923f6ff
Authored: 2022-07-22 02:27:34 -0400
Committed: 2022-07-22 12:22:12 -0400

Relaxing checks for MULT16_32_QX()

MULT16_32_QX() is now implemented using a signed-unsigned multiply,
so the second argument can now have one extra bit compared to the
old signed-signed implementation.

Reviewed by Mark Harris

Files Modified:

• celt/fixed_debug.h

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=514c3c86570c72b5a4da8b0727a4b8bc700505b1

Comment 2

[Update Bot]

Attachment: Bug 1780854 - Update opus to 378b4e5fc31b63c1f1a9f6a87a62609c5a083724

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).