Closed Bug 1780876 Opened 3 years ago Closed 3 years ago

Intermittent browser/components/extensions/test/browser/browser_ext_windows_create.js | single tracking bug

Categories

(WebExtensions :: Untriaged, defect, P5)

defect

Tracking

(firefox-esr91 unaffected, firefox-esr102 unaffected, firefox103 unaffected, firefox104 wontfix, firefox105 wontfix, firefox106 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- wontfix
firefox105 --- wontfix
firefox106 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [retriggered])

Attachments

(1 file)

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=385159261&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OZ-XmXLlTAiEptod2XPppw/runs/0/artifacts/public/logs/live_backing.log


[task 2022-07-22T20:32:32.096Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Got expected value for window.state - Expected: minimized, Actual: minimized - 
[task 2022-07-22T20:32:32.096Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | tabs property got populated - Expected: 1, Actual: 1 - 
[task 2022-07-22T20:32:32.097Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Expected window state to be STATE_MINIMIZED - 
[task 2022-07-22T20:32:32.097Z] 20:32:32     INFO - Buffered messages logged at 20:32:29
[task 2022-07-22T20:32:32.097Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Expected window.state (currently normal) to be "normal" but will accept "maximized" - 
[task 2022-07-22T20:32:32.098Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | tabs property got populated - Expected: 1, Actual: 1 - 
[task 2022-07-22T20:32:32.098Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Expected windowState (currently 3) to be STATE_NORMAL but will accept STATE_MAXIMIZED - 
[task 2022-07-22T20:32:32.099Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Got expected hidden chrome - 
[task 2022-07-22T20:32:32.099Z] 20:32:32     INFO - Buffered messages finished
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_windows_create.js | Got expected value for window.state - Expected: fullscreen, Actual: normal - 
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - Stack trace:
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - chrome://mochikit/content/browser-test.js:test_ok:1400
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:83
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:97
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - resource://specialpowers/SpecialPowersChild.jsm:listener:2020
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - resource://specialpowers/SpecialPowersChild.jsm:loadExtension/<:1950
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - resource://specialpowers/SpecialPowersChild.jsm:receiveMessage:253
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - JSActor query*resource://specialpowers/SpecialPowersParent.jsm:resultListener:1120
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - resource://gre/modules/ExtensionCommon.jsm:emit:320
[task 2022-07-22T20:32:32.101Z] 20:32:32     INFO - resource://gre/modules/Extension.jsm:receiveMessage:2535
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - MessageListener.receiveMessage*resource://gre/modules/Extension.jsm:Extension:2339
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:673
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - resource://specialpowers/SpecialPowersParent.jsm:receiveMessage:1117
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - JSActor query*resource://specialpowers/SpecialPowersChild.jsm:loadExtension:2012
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:128
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_windows_create.js:testWindowCreate:6
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/browser-test.js:handleTask:988
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1060
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1195
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:977
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2022-07-22T20:32:32.102Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | tabs property got populated - Expected: 1, Actual: 1 - 
[task 2022-07-22T20:32:32.103Z] 20:32:32     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create.js | Expected window state to be STATE_FULLSCREEN - 
Whiteboard: [retriggered]

Just to confirm, this happens only on macOS right?

Flags: needinfo?(apavel)
Flags: needinfo?(apavel)
Blocks: 1780998
Flags: needinfo?(emilio)

The patch that that regressed this started using the widget state rather
than the DOM state to return full-screen. It seems on macOS they
sometimes can get out of sync, in the failure from comment 0 the window
is really full-screen.

We seemed to account for some of this in:

https://searchfox.org/mozilla-central/rev/00e504083572d47f2199168f0f79c75c0ddaefb3/browser/components/extensions/test/browser/browser_ext_windows_create.js#31-36

Make sure we exit full-screen as appropriate if DOM thinks we're
fullscreen. This passes verify and at worst it should be harmless.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fd28095481d Try to deal with DOM/widget state mismatch on macOS. r=robwu
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
See Also: → 1788204
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: