1780973 - When rapidly clicking the One Year Forward button in Today Pane to go decades in the future, TB will lock up, be Not Responding and consuming 10-20% CPU in icaltime_compare

Status: NEW

(Calendar :: General, defect)

Description

Using 103.0b6,

STR:

1. Make sure Today Pane (F11) is visible
2. Repeatedly click the One Year Forward button so that you arrive at, let's say, 2080 (if TB makes it that far) and then stop

Expected Result:

1. TB will arrive at 2080 without issue, locking up or consuming CPU cycles

Actual Result:

1. TB arrives at 2080, eventually after catching up with the repeated button clicks, and locks up or becomes Not Responding with 10-20% CPU use

This could be related to what I did in bug 1780918 comment 1

Requires me to End Task on the running TB processes to get back to a working state.

Comment 1

[Arthur K. (he/him)]

Still very present in 106.0b1. Took quite a few attempts but this is what I'm seeing in profiler: https://share.firefox.dev/3dw9x1x

Incidentally, I can't get super granular and leverage all the other additional logging features under "Features" or "Experimental" or TB throws an error message or falls over. Hope there's something useful here.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Arthur K. (he/him) from comment #1)

Still very present in 106.0b1. Took quite a few attempts but this is what I'm seeing in profiler: https://share.firefox.dev/3dw9x1x

This looks different than the profile in bug 1789999 comment 13

Incidentally, I can't get super granular and leverage all the other additional logging features under "Features" or "Experimental" or TB throws an error message or falls over. Hope there's something useful here.

Arthur, can you email me details?

Comment 3

[Geoff Lankow (:darktrojan)]

This looks different than the profile in bug 1789999 comment 13

You're now hitting the "calculating occurrences can be very slow" problem. I would assume that with no calendars enabled this bug doesn't happen. Is that the case?

Comment 4

[Arthur K. (he/him)]

(In reply to Geoff Lankow (:darktrojan) from comment #3)

This looks different than the profile in bug 1789999 comment 13

You're now hitting the "calculating occurrences can be very slow" problem. I would assume that with no calendars enabled this bug doesn't happen. Is that the case?

Yup.

Comment 5

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #2)

(In reply to Arthur K. (he/him) from comment #1)

Still very present in 106.0b1. Took quite a few attempts but this is what I'm seeing in profiler: https://share.firefox.dev/3dw9x1x

This looks different than the profile in bug 1789999 comment 13

Incidentally, I can't get super granular and leverage all the other additional logging features under "Features" or "Experimental" or TB throws an error message or falls over. Hope there's something useful here.

Arthur, can you email me details?

Which details specifically do you need? The profile info doesn't help any?

Comment 6

[Arthur K. (he/him)]

This is how we're looking with 108.0b3. Still present but no longer locks up TB to the point that I have to end-task on the process to get back to functioning TB. CPU does spike but it seems to clear up after 30 seconds or so if TB is left to catch up to whatever it's thinking about.

https://share.firefox.dev/3UP2TTG

Comment 7

[Wayne Mery (:wsmwk)]

Sorry, didn't get to this profile. Does the issue still reproduce in a current version?

Comment 8

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #7)

Sorry, didn't get to this profile. Does the issue still reproduce in a current version?

Afraid so. I tested with the 115.1.0 candidate and went up to the year 2101. TB gets stuck in a state of Responding > Not Responding > Responding > Not Responding with RAM slowly creeping upwards. Tried to capture a perf profile but once TB went off the reservation it never came back. Console was complaining about this below but might not be related:

Failed to get the active browserId while starting the profiler. recording-utils.js:29:11
getActiveBrowserID resource://devtools/shared/performance-new/recording-utils.js:29
startProfiler resource://devtools/server/actors/perf.js:63
handler resource://devtools/shared/protocol/Actor.js:198
onPacket resource://devtools/server/devtools-server-connection.js:379
_onJSONObjectReady resource://devtools/shared/transport/transport.js:463
makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103