1781061 - Emit JSOp::DebugCheckSelfHosted in more places

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Tooru Fujisawa [:arai]]

Bug 1609432 will add callContentFunction and constructContentFunction to all callsites where the callee can be content functions.
That means, in all other cases, the callee must be self-hosted function or built-in.
We can add JSOp::DebugCheckSelfHosted to all calls except for the above 2, so that
onNativeCall and eager evaluation keeps working.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 0: Do not use Array.from in eager evaluation test. r?nchevobbe!

Array.from on an iterable object internally calls
%ArrayIteratorPrototype%.next, which is effectful.

The later patches will add more coverage inside for-of loop inside
self-hosted JS, and that will expose the call on obj[Symbol.iterator]().next,
which can be %ArrayIteratorPrototype%.next or any other function.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 1: Add missing callContentFunction in sort. r?jandem!

Depends on D153153

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 2: Remove self-hosted module code handling. r?jandem!

Depends on D153154

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 3: Add SelfHostedIter::{Allow,Deny} enum and use it in all functions that can call iteration related function. r?jandem!

Depends on D153155

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 4: Cleanup stack comment and remove unused CallOrNewEmitter method. r?jandem!

Depends on D153156

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 5: Disallow non-name callee in self-hosted JS. r?jandem!

Depends on D153157

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 6: Add JSOp::CallContentIter. r?jandem!

Depends on D153158

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 7: Use JSOp::CallContentIter instead of JSOp::CallIter in self-hosted JS. r?jandem!

Depends on D153159

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 8: Emit JSOp::DebugCheckSelfHosted in all case. r?jandem!

Depends on D153160

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 9: Add eager evaluation test for crafted iterable. r?nchevobbe!

Depends on D153161

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781061 - Part 10: Add eager evaluation test for reused iterator. r?nchevobbe!

Depends on D153162

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a547dbb387b
Part 0: Do not use Array.from in eager evaluation test. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6dec44311fb1
Part 1: Add missing callContentFunction in sort. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a7621b225cb3
Part 2: Remove self-hosted module code handling. r=jandem
https://hg.mozilla.org/integration/autoland/rev/52431c4b1588
Part 3: Add SelfHostedIter::{Allow,Deny} enum and use it in all functions that can call iteration related function. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f0554d74eedb
Part 4: Cleanup stack comment and remove unused CallOrNewEmitter method. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6f9dde36dbd8
Part 5: Disallow non-name callee in self-hosted JS. r=jandem
https://hg.mozilla.org/integration/autoland/rev/aa5f3bf898bc
Part 6: Add JSOp::CallContentIter. r=jandem
https://hg.mozilla.org/integration/autoland/rev/178d1de9debb
Part 7: Use JSOp::CallContentIter instead of JSOp::CallIter in self-hosted JS. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7e49b9f5abc1
Part 8: Emit JSOp::DebugCheckSelfHosted in all case. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c2480e13b36d
Part 9: Add eager evaluation test for crafted iterable. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/19cb3c811aae
Part 10: Add eager evaluation test for reused iterator. r=nchevobbe

Comment 13

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/5a547dbb387b
https://hg.mozilla.org/mozilla-central/rev/6dec44311fb1
https://hg.mozilla.org/mozilla-central/rev/a7621b225cb3
https://hg.mozilla.org/mozilla-central/rev/52431c4b1588
https://hg.mozilla.org/mozilla-central/rev/f0554d74eedb
https://hg.mozilla.org/mozilla-central/rev/6f9dde36dbd8
https://hg.mozilla.org/mozilla-central/rev/aa5f3bf898bc
https://hg.mozilla.org/mozilla-central/rev/178d1de9debb
https://hg.mozilla.org/mozilla-central/rev/7e49b9f5abc1
https://hg.mozilla.org/mozilla-central/rev/c2480e13b36d
https://hg.mozilla.org/mozilla-central/rev/19cb3c811aae