1781084 - Add CSS transitions when moving Feature Callout from one element to the next

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

When the Feature Callout moves from one element to the next, use a transition to make the change feel less abrupt.

We'll need guidance from design on the style of transitions.

Comment 1

[Meg Viar [:mviar]]

Design confirmed we'll use a simple fade in and fade out transition when the callout moves positions. We should use timing similar to the fade transitions in about:welcome.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1781084 - Add CSS transitions when moving Feature Callout from one element to the next

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8048378aaae9
Add CSS transitions when moving Feature Callout from one element to the next r=Mardak

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing node newtab failures on _feature-callout.scss

Backout link

Push with failures

Failure log

Comment 5

[Meg Viar [:mviar]]

Resolved, thanks for flagging.

Comment 6

[Norisz Fay [:noriszfay]]

There seems to be this other failure too (failure log here) if you could take a look at it. Thank you!

Comment 7

[Meg Viar [:mviar]]

Thanks, Norisz. I've updated the patch to address this issue.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0306b5b024ee
Add CSS transitions when moving Feature Callout from one element to the next r=Mardak

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_feature_callout.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&tochange=abf0d47dc16bb3c596b9dc634434abb9561cb698&fromchange=0306b5b024ee34a6545d1b54ca5e1932da4a9df8&test_paths=browser%2Fcomponents%2Ffirefoxview%2Ftests%2Fbrowser&selectedTaskRun=Y90RnukmT9CN4aXNwdNypw.1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=387161553&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0e4d7a1b66f0c0f5bbeb066b2faef0b567c8e925

Comment 10

[Meg Viar [:mviar]]

Thanks, Cosmin. I'll update the patch to address that issue (thanks to some debugging help from @mardak!) and another resulting from a related patch that landed. I'll attempt to land again once it passes on try.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33e06b95b4e7
Add CSS transitions when moving Feature Callout from one element to the next r=Mardak

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/33e06b95b4e7

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from here and I can confirm that the tour screens fade and reappear in a new location at each click of the primary button.

Verified using the latest Firefox Nightly (105.0a1 Build ID - 20220816095503) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.

Comment 14

[Cristian Tuns]

Backed out temporarily to test if is the cause of bug 1784591

• Backout link

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/423c491c8f31
Add CSS transitions when moving Feature Callout from one element to the next r=Mardak