Closed Bug 1781086 Opened 5 months ago Closed 4 months ago

Close & update pref on dismiss button click in Feature Callout

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
105 Branch
Iteration:
105.2 - Aug 8 - Aug 19
Tracking Status
firefox105 --- verified

People

(Reporter: mviar, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Clicking Feature Callout dismiss button should set the feature callout pref to show the tour as complete and record the last viewed screen.

Priority: -- → P2
Iteration: --- → 105.1 - July 25 - Aug 5
Priority: P2 → P1
Assignee: nobody → mviar
Summary: Handle dismiss telemetry in Feature Callout → Handle dismiss telemetry & close on dismiss button click in Feature Callout
Attachment #9288539 - Attachment description: WIP: Bug 1781086 - Handle dismiss telemetry in Feature Callout → Bug 1781086 - Handle dismiss telemetry in Feature Callout
Iteration: 105.1 - July 25 - Aug 5 → 105.2 - Aug 8 - Aug 19
Blocks: 1783222
Summary: Handle dismiss telemetry & close on dismiss button click in Feature Callout → Close & update pref on dismiss button click in Feature Callout
Attachment #9288539 - Attachment description: Bug 1781086 - Handle dismiss telemetry in Feature Callout → Bug 1781086 - Handle dismiss in Feature Callout
Attachment #9288539 - Attachment description: Bug 1781086 - Handle dismiss in Feature Callout → Bug 1781086 - Handle dismiss telemetry in Feature Callout
Pushed by mviar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb8a17098279
Handle dismiss telemetry in Feature Callout r=Mardak
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220811190443) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

  • The “CLICK_BUTTON” event pings are correctly displayed in the Browser Console after clicking the “x” button from the Firefox View feature tour screens. It correctly indicates the event_context ("event_context":"{"source":"dismiss_button","page":"about:firefoxview"}”), and the last viewed screen:
    • "message_id":"FIREFOX_VIEW_FEATURE_TOUR_0_FEATURE_CALLOUT_1" if the Firefox View feature tour is dismissed from the first screen;
    • "message_id":"FIREFOX_VIEW_FEATURE_TOUR_0_FEATURE_CALLOUT_2" if the Firefox View tour is dismissed from the second screen;
    • "message_id":"FIREFOX_VIEW_FEATURE_TOUR_0_FEATURE_CALLOUT_3" if the Firefox View tour is dismissed from the third screen;
  • Also, the value of the pref is set to:
    -“{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":true}” if the Firefox View feature tour is dissmed from the first screen.
    -“{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_2","complete":true}” if the Firefox View feature tour is dissmed from the second screen.
    -“{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_3","complete":true}” if the Firefox View feature tour is dissmed from the third screen.
  • I also confirm that no “DISMISS” event is displayed in the Browser Console when a screen of the Firefox View feature tour is dismissed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.