Closed Bug 1781215 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35233 - Move AffectedBySubjectHas flag to HasInvalidationFlags.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35233 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35233
Details from upstream follow.

Byungwoo Lee <blee@igalia.com> wrote:

Move AffectedBySubjectHas flag to HasInvalidationFlags.

:has() invalidation doesn't work properly when the :has() pseudo
class is in the subject position and the 'display' property of the
:has() anchor element is 'none' since the 'AffectedBySubjectHas'
flag is in the computed style extra fields.

To fix the bug, this CL moves the AffectedBySubjectHas flag to the
HasInvalidationFlags so that the flag can be stored in the element
rare data.

Like the other :has() related flags in HasInvalidationFlags, the
AffectedBySubjectHas flag will not be cleared after the flag is set.

Bug: 1347181
Change-Id: I98d68c87433f7c1a9a169ea1c471993336216f1d
Reviewed-on: https://chromium-review.googlesource.com/3787517
WPT-Export-Revision: 96bc2119cd441f7fa44055f167b51d304e90fb72

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eadb96e446df
[wpt PR 35233] - Move AffectedBySubjectHas flag to HasInvalidationFlags., a=testonly
https://hg.mozilla.org/integration/autoland/rev/44afc30ccd66
[wpt PR 35233] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eadb96e446df
https://hg.mozilla.org/mozilla-central/rev/44afc30ccd66

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.