Closed Bug 1781321 Opened 4 years ago Closed 3 years ago

Perma devtools/server/tests/browser/browser_accessibility_text_label_audit.js | single tracking bug

Categories

(DevTools :: Accessibility Tools, defect, P3)

defect

Tracking

(firefox-esr102 unaffected, firefox106 unaffected, firefox107 unaffected, firefox108 fixed)

RESOLVED FIXED
108 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- unaffected
firefox108 --- fixed

People

(Reporter: jmaher, Assigned: nlapre)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1781321

Regressed by: 1748585
Summary: Intermittent devtools/server/tests/browser/browser_accessibility_text_label_audit.js | single tracking bug → Perma devtools/server/tests/browser/browser_accessibility_text_label_audit.js | single tracking bug

Set release status flags based on info from the regressing bug 1748585

:nlapre, since you are the author of the regressor, bug 1748585, could you take a look?

For more information, please visit auto_nag documentation.

Yup, looks like my fault, sorry. Will have a patch to update the test today. To summarize, there's a test that has an img element with alt="". I made a change to the accessibility code so that we no longer create an accessible for images with empty alt text (this is now considered decorative). I think the solution here is simply to remove the test since it's no longer intended for an accessible to be created here.

This revision fixes these failing tests. I made a change in Bug 1748585 which
causes img elements with alt="" to be considered decorative (in most cases).
These tests rely on the accessible existing in the tree, so I've removed them.
I don't think it makes sense to test this any more. FWIW, I've made the same
changes to accessibility tests in the accessible directory.

Assignee: nobody → nlapre
Status: NEW → ASSIGNED
Flags: needinfo?(nlapre)
Pushed by nlapre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1f1440164f8 Fix devtools browser a11y tests for img elements with no alt text, r=morgan
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
See Also: → 1799294
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: