1781361 - Implement set Firefox Default Home Page option in existing users colorways screen

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add checkbox option to set Firefox Default Home Page in existing users colorways screen

Comment 1

[Ed Lee :Mardak]

Potentially this could be implemented with bug 1777386 MULTI_ACTION. Where an action is defined on a checkbox configuration and gets combined with the primary button action which would then check if the checkbox is checked to dynamically combine.

I think for now, we can rely on OnboardingMessageProvider.getUpgradeMessage to determine if the checkbox config should be removed -- here if the homepage pref is already default value.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1781361 - impl set home page option for upgraders, r?Mardak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5a97ca54feb
impl set home page option for upgraders, r=Mardak

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a5a97ca54feb

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a5a97ca54feb

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm the following:

• The "Make Firefox Home your colorful homepage" checkbox option is successfully displayed on the "Colorways" modal if a custom homepage is set.
• The "Make Firefox Home your colorful homepage" checkbox option is NOT displayed on the "Colorways" modal if the default homepage is set.
• The homepage is reset to the default one if the checkbox is checked and the "Set colorway" button is clicked.
• The homepage is NOT reset to the default one if the checkbox is checked but the "Skip this step" button is clicked.
• The homepage is NOT reset to the default one if the checkbox is NOT checked and the "Set colorway" button is clicked.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220828210513) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.