Closed Bug 1781378 Opened 2 years ago Closed 2 years ago

Add final MR onboarding strings

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
105 Branch
Iteration:
105.2 - Aug 8 - Aug 19
Tracking Status
firefox105 --- verified

People

(Reporter: pdahiya, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Scope of this bug is to update MR onboarding fluent files with strings expected to be finalized by August 4th.

Iteration: --- → 105.1 - July 25 - Aug 5
Priority: -- → P1

NI @Ania to help update bug with figma when final strings are good to use for localization thanks

Flags: needinfo?(asafko)

Hi!
All the strings have been finalized and are ready to be added to the build:
New users
Existing users

Please note that a few screens have notes for our translation community in Figma comments. Let's please make sure they are added to Pontoon, so that there's enough context around colloquialisms used in English.

Flags: needinfo?(asafko)
Iteration: 105.1 - July 25 - Aug 5 → 105.2 - Aug 8 - Aug 19
Assignee: nobody → jprickett

NI @pdahiya does the scope of this bug include updating JSON to use ftl string ids?

Flags: needinfo?(pdahiya)

(In reply to Jason Prickett from comment #3)

NI @pdahiya does the scope of this bug include updating JSON to use ftl string ids?

That's correct patch should add new strings and update respective JSON in new and existing user onboarding to use the string ids

Flags: needinfo?(pdahiya)
Blocks: 1779514
Pushed by jprickett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5fd749503d0
Adding final MR onboarding strings r=pdahiya,fluent-reviewers,flod,Mardak
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

I have verified this enhancement and I can confirm that all the strings from the already implemented "about:welcome" screens and the existing users modals respect the Figma specifications.

Also, we observed that the "Skip this step" button from the "Import Data" and "Prin Private Window" screens is no longer correctly displayed, however, we logged a separate issue for this (see bug 1786246).

Verified using the latest Firefox Nightly 105.0a1 (Build ID: 20220821185924) installed on Windows 10 x64, macOS 11.6.7, and Linux Mint 20.2.

Status: RESOLVED → VERIFIED
Blocks: 1791002
See Also: → 1823021
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: