1781442 - [wpt-sync] Sync PR 34744 - Don't re-lock DisplayLocks during forced unlock

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34744
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Don't re-lock DisplayLocks during forced unlock

When a DisplayLock is unlocked via ForceUnlockIfNeeded, subsequent
updates to the DisplayLock can cause it to become locked again which is
problematic.

This patch prevents the DisplayLock from being locked again until the
next frame.

Fixed: 1338135
Change-Id: I07790658e25ea9fe2f4e8de154e3a58e7e08892b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3751710
Commit-Queue: Joey Arhar \<[e-mail]>
Reviewed-by: Vladimir Levin \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1028405}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dc0485644602fb0c1d0c2aed09eeb9b9cba83e6

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

TIMEOUT: 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fullscreen/crashtests/content-visibility-crash.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ef2fd8b1830
[wpt PR 34744] - Don't re-lock DisplayLocks during forced unlock, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dbc72f79a3e8
[wpt PR 34744] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3ef2fd8b1830
https://hg.mozilla.org/mozilla-central/rev/dbc72f79a3e8