1781504 - Intermittent devtools/client/styleeditor/test/browser_toolbox_styleeditor.js | single tracking bug

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P3)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1781504

Comment 3

[Intermittent Failures Robot]

3 failures in 3057 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform and build breakdown:

• windows10-32-2004-qr: 2
  • debug: 2
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-08-01&endday=2022-08-07&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 2916 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-08-15&endday=2022-08-21&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 3293 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-08-22&endday=2022-08-28&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 3034 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-10-10&endday=2022-10-16&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 3743 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-10-24&endday=2022-10-30&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 3626 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-10-31&endday=2022-11-06&tree=all

Comment 9

[Intermittent Failures Robot]

1 failures in 3445 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-11-07&endday=2022-11-13&tree=all

Comment 10

[Intermittent Failures Robot]

1 failures in 3888 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-11-21&endday=2022-11-27&tree=all

Comment 11

[Intermittent Failures Robot]

2 failures in 3938 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 1

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 1
  • opt: 1
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-11-28&endday=2022-12-04&tree=all

Comment 12

[Intermittent Failures Robot]

2 failures in 3558 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• try: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1
• windows10-64-2004-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-12-12&endday=2022-12-18&tree=all

Comment 13

[Intermittent Failures Robot]

24 failures in 2999 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 19
• mozilla-central: 5

Platform and build breakdown:

• linux1804-64-qr: 15
  • opt: 14
  • debug: 1
• linux1804-64-shippable-qr: 9
  • opt: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-12-19&endday=2022-12-25&tree=all

Comment 14

[Intermittent Failures Robot]

13 failures in 1328 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• autoland: 8
• mozilla-central: 4

Platform and build breakdown:

• linux1804-64-shippable-qr: 11
  • opt: 11
• linux1804-64-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2022-12-26&endday=2023-01-01&tree=all

Comment 15

[Natalia Csoregi [:nataliaCs]]

Update

There have been 31 failures within the last 7 days:

• 8 failures on Linux 18.04 x64 WebRender opt
• 22 failures on Linux 18.04 x64 WebRender Shippable opt
• 1 failure on Windows 10 x64 2004 WebRender opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=401696836&repo=mozilla-central&lineNumber=7777

[task 2023-01-07T23:27:58.115Z] 23:27:58     INFO - TEST-PASS | devtools/client/styleeditor/test/browser_toolbox_styleeditor.js | Has session state - 
[task 2023-01-07T23:27:58.116Z] 23:27:58     INFO - Buffered messages logged at 23:25:01
[task 2023-01-07T23:27:58.117Z] 23:27:58     INFO - Console message: [JavaScript Warning: "debuggee 'resource://devtools/shared/loader/base-loader.js:321' would run" {file: "resource://devtools/shared/loader/builtin-modules.js" line: 105}]
[task 2023-01-07T23:27:58.119Z] 23:27:58     INFO - Console message: [JavaScript Warning: "debuggee 'resource://devtools/shared/loader/base-loader.js:321' would run" {file: "resource://devtools/shared/loader/builtin-modules.js" line: 105}]
[task 2023-01-07T23:27:58.120Z] 23:27:58     INFO - Buffered messages logged at 23:25:42
[task 2023-01-07T23:27:58.120Z] 23:27:58     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 3
[task 2023-01-07T23:27:58.121Z] 23:27:58     INFO - Buffered messages logged at 23:26:27
[task 2023-01-07T23:27:58.122Z] 23:27:58     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2023-01-07T23:27:58.122Z] 23:27:58     INFO - Buffered messages logged at 23:27:12
[task 2023-01-07T23:27:58.122Z] 23:27:58     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2023-01-07T23:27:58.123Z] 23:27:58     INFO - Buffered messages finished
[task 2023-01-07T23:27:58.124Z] 23:27:58     INFO - TEST-UNEXPECTED-FAIL | devtools/client/styleeditor/test/browser_toolbox_styleeditor.js | Test timed out - 
[task 2023-01-07T23:27:58.124Z] 23:27:58     INFO - Removing tab.
[task 2023-01-07T23:27:58.125Z] 23:27:58     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2023-01-07T23:27:58.125Z] 23:27:58     INFO - Got event: 'TabClose' on [object XULElement].
[task 2023-01-07T23:27:58.126Z] 23:27:58     INFO - Tab removed and finished closing
[task 2023-01-07T23:27:58.128Z] 23:27:58     INFO - TEST-PASS | devtools/client/styleeditor/test/browser_toolbox_styleeditor.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-01-07T23:27:58.172Z] 23:27:58     INFO - GECKO(7918) | MEMORY STAT | vsize 4230MB | residentFast 750MB | heapAllocated 412MB

Julian, any chance you could help us assign the bug to someone?
Thank you.

Comment 16

[Intermittent Failures Robot]

32 failures in 2607 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #36 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 9
• autoland: 22
• try: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 22
  • opt: 22
• linux1804-64-qr: 8
  • opt: 8
• windows10-64-2004-qr: 1
  • opt: 1
• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2023-01-02&endday=2023-01-08&tree=all

Comment 17

[Julian Descottes [:jdescottes]]

Attachment: toolbox_connection_timeout.png

It seems that the browser toolbox fails to connect, and we have the following error in the logs

console.error: (new Error("Target already destroyed, unable to fetch children fronts", "resource://devtools/client/fronts/targets/target-mixin.js", 302))

But no stack trace.

Alex, you already encountered this particular issue when investigating another intermittent (https://phabricator.services.mozilla.com/D143219#4687414). Any suggestion on how we could fix this? Otherwise we can skip on linux opt for now, it seems to only happen on this platform.

I'm doing a push to try to try to get better logs: https://treeherder.mozilla.org/jobs?repo=try&revision=52ec87bb3520b0f3770d632ff6a1a6fa31407429

Comment 18

[Julian Descottes [:jdescottes]]

Ok we have a slightly helpful stacktrace:

[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/client/fronts/targets/target-mixin.js 302 getFront
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/shared/commands/target/target-command.js 950 getAllFronts
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/shared/commands/thread-configuration/thread-configuration-command.js 46 updateConfiguration
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/client/debugger/src/client/firefox.js 78 onConnect
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/client/debugger/src/main.js 104 bootstrap
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/client/debugger/panel.js 68 open
[task 2023-01-09T10:44:08.838Z] 10:44:08 INFO - GECKO(1569) | 3494> resource://devtools/client/framework/toolbox.js 2608 onLoad

So that's very similar to the fix done on https://phabricator.services.mozilla.com/D143219#4687414 , it's just the getAllFronts call right above which fails. I can take a look.

Comment 19

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1781504 - [devtools] Fix browser_toolbox_styleeditor.js intermittent.

I suspect we are using getAllTargetsInSelectedTargetTree which could theoritically
return destroyed targets as it is async.
If we are using getAllTargets, this is less clear. It shouldn't return destroyed target.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2dacaf56c3
[devtools] Fix browser_toolbox_styleeditor.js intermittent. r=jdescottes

Comment 21

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9d2dacaf56c3

Comment 22

[Cristian Tuns]

This is still happening, on autoland: https://treeherder.mozilla.org/logviewer?job_id=401964479&repo=autoland

Comment 23

[Julian Descottes [:jdescottes]]

Let's monitor the frequency. The failure shows that we managed to start the toolbox successfully here, but we seem to fail during the toolbox task, possibly around the end of it: https://searchfox.org/mozilla-central/rev/a156a65ced2dae5913ae35a68e9445b8ee7ca457/devtools/client/styleeditor/test/browser_toolbox_styleeditor.js#64-79

For instance we could be stuck on the first await highlighted here, because the failure screenshot shows that we have not updated the stylesheet...

Comment 24

[Julian Descottes [:jdescottes]]

Resetting the assignee, the patch from Alex had the expected effect and we are now seeing a different issue.

Comment 25

[Julian Descottes [:jdescottes]]

Attachment: simple_css_selected_by_default.png

I think the issue is just that in some cases simple.css is listed first, and therefore already selected, which makes the test timeout.

Comment 26

[Julian Descottes [:jdescottes]]

Attachment: Bug 1781504 - [devtools] Check if simple.css is already selected in browser_toolbox_styleeditor.js

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9d214f3f36d
[devtools] Check if simple.css is already selected in browser_toolbox_styleeditor.js r=ochameau

Comment 28

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f9d214f3f36d

Comment 29

[Intermittent Failures Robot]

8 failures in 3530 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7
• try: 1

Platform and build breakdown:

• linux1804-64-qr: 5
  • opt: 5
• linux1804-64-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1781504&startday=2023-01-09&endday=2023-01-15&tree=all