1781528 - Add Arrow to secondary button CTA

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add arrow to secondary button as per figma

https://www.figma.com/file/2TrMkNefxzhMCXjUqM8KIy/MR1-2022-Onboarding?node-id=3492%3A69275

Comment 1

[Meg Viar [:mviar]]

UX confirmed we can use this existing arrow asset: https://searchfox.org/mozilla-central/source/browser/themes/shared/icons/forward.svg

Comment 2

[Negin]

Attachment: Bug 1781528 - Add Arrow to secondary button CTA

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd7adf24ee07
Add Arrow to secondary button CTA r=emcminn

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dd7adf24ee07

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have tested this enhancement using the latest Firefox Nightly (106.0a1 Build ID - 20220824093620) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64 and it seems that the arrow is not displayed on the secondary CTA button from the "about:welcome" screens or the upgrading modals.

Considering the above I am reopening this issue.

Comment 6

[Negin]

Attachment: Bug 1781528 - Add Arrow to secondary button CTA r?mardak

Comment 7

[Negin]

Attachment: Bug 1781528 - Add Arrow to secondary button CTA r?mardak

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dab3ab0411fc
Add Arrow to secondary button CTA r=Mardak

Comment 9

[Negin]

(In reply to Marius Coman [:mcoman], Ecosystem QA from comment #5)

I have tested this enhancement using the latest Firefox Nightly (106.0a1 Build ID - 20220824093620) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64 and it seems that the arrow is not displayed on the secondary CTA button from the "about:welcome" screens or the upgrading modals.

Considering the above I am reopening this issue.

My mistake! I configured the setup for showing the arrow icon on the secondary button CTAs but did not add them to the appropriate JSON/screens so it was not testable. This should be resolved now and testable. (The corresponding screens to the figma file will now have the secondary buttons with the arrow icon. )

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dab3ab0411fc

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 106.0a1 (Build ID: 20220825222149) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The “Skip this step” buttons contain the right arrow.

During verifying this enhancement, I noticed that the arrow has a black color when the browser’s dark theme is enabled. I filled a new issue (Bug 1787386) for this behavior.