1781536 - [CTW] Unify RelationByType in Accessible base

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Bug 1774043 added caching for relations. However, there are still different methods for LocalAccessible and RemoteAccessible; there's no common method in the base Accessible. Unifying this is necessary in order to support relations on Windows for cached RemoteAccessible, as well as cleaning up relations code for other platforms.

This is going to be a bit trickier than unifying other methods because LocalAccessible::RelationByType returns a Relation, but RemoteAccessible::RelationByType returns an array. Relation doesn't know how to handle RemoteAccessible, so it will need to be unified as well.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1781536 part 1: Support base Accessible in Relation.

Previously, Relation::Next returned a LocalAccessible.
Now, it returns an Accessible so that it can support RemoteAccessible as well.
Relation::LocalNext has been added as a convenience to return a LocalAccessible when the caller is certain that only LocalAccessible is relevant.
Callers have either been updated to use LocalNext or to handle an Accessible returned from Next.
ia2AccessibleRelation now holds an array of MsaaAccessible, as we need to hold references and we can't hold references to RemoteAccessible.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1781536 part 2: Introduce RemoteAccIterator.

This is basically RemoteExplicitHeadersIterator with naming generalised.
Support has been added for transferring ownership of the array into the iterator, which will be needed when the cache is disabled.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1781536 part 3: Move RelationByType to base Accessible.

This required changing the RemoteAccessible implementations to return Relation instead of an array of RemoteAccessible.
Platform implementations have been updated to use the unified method where appropriate.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d31c0604efe
part 1: Support base Accessible in Relation. r=morgan
https://hg.mozilla.org/integration/autoland/rev/95ae96802dbe
part 2: Introduce RemoteAccIterator. r=morgan
https://hg.mozilla.org/integration/autoland/rev/86da8f2a28ea
part 3: Move RelationByType to base Accessible. r=morgan

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8d31c0604efe
https://hg.mozilla.org/mozilla-central/rev/95ae96802dbe
https://hg.mozilla.org/mozilla-central/rev/86da8f2a28ea