178157 - Dependency emails don't get sent for status change during mass change

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Bradley Baetz (:bbaetz)]

We send dependancy mails based on the incorrectly named 'dependencychanged' hash
in process_bug. This seems to be reading from the form value, and then later
ading any change values. For mass changes, the form value will be blank, and
there will be no changes, so the hash is empy, and processmail isn't called on
mass resolves.

The info is sent the next time mail happens on the bug, for whatever reason.

myk, is |processmail -rescanall| still being run semi-regularly?

Comment 1

[Bradley Baetz (:bbaetz)]

(OK, its not really dataloss, since the mail will get send eventually. Its still
Not Good)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Yes, it's run once a day early in the morning.

Comment 3

[Brant Gurganus]

By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity.  Only changing open bugs to
minimize unnecessary spam.  Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.

Comment 4

[Gervase Markham [:gerv]]

bbaetz: do you know what the solution is here?

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

See my comment 0.

Comment 6

[Frédéric Buclin]

Taking! I know process_bug.cgi by heart now :)

Comment 7

[Frédéric Buclin]

Attachment: patch, v1

Applies to both 2.18 and the trunk. We now check for dependencies even if the
corresponding fields are not available from the UI (which is the case when
changing several bugs at once).

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 177775 [details] [diff] [review]
patch, v1

Looks like it works, but the new looping code is hard to grok.	I suggest not
changing the original code or changing it to something a little easier to
understand, f.e.:

foreach my ($pair) = ("blocked/dependson", "dependson/blocked") {
  my ($source, $target) = split("/", $pair);
  ...
}

Comment 9

[Frédéric Buclin]

Attachment: patch, v2

Nit fixed!

Comment 10

[Frédéric Buclin]

Tip:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.243; previous revision: 1.242
done


2.18 Branch:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205.2.16; previous revision: 1.205.2.15
done