Closed Bug 1781786 Opened 2 years ago Closed 2 years ago

Switching to scrolling-boxes.html tab became slower after bug 1779952

Categories

(Core :: Graphics: WebRender, defect)

Firefox 105
x86_64
Linux
defect

Tracking

()

VERIFIED FIXED
105 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 --- verified

People

(Reporter: gregp, Assigned: gw)

References

(Blocks 1 open bug, Regression, )

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce:

  1. Navigate to https://web.archive.org/web/20110313233153id_/https://people.mozilla.org/~roc/scrolling-boxes.html
  2. Open a new tab
  3. Switch back to scrolling-boxes.html

Actual results:
Takes a bit of time

Expected results:
Takes a bit less time.

I also noticed that interactive performance of the browser UI is really bad with scrolling-boxes.html open. It took 500ms for the address bar to finish opening in one case, very strange.

Tab switching before bug 1779952: https://share.firefox.dev/3BjvBpG
Tab switching after bug 1779952: https://share.firefox.dev/3zBp9Jv
Moving cursor around the browser UI, opening the address bar before bug 1779952 with scrolling-boxes.html open: https://share.firefox.dev/3zdyDsN
Moving cursor around the browser UI, opening the address bar after bug 1779952 with scrolling-boxes.html open: https://share.firefox.dev/3PVUr31

Blocks: wr-perf
Severity: -- → S3
Flags: needinfo?(gwatson)

Set release status flags based on info from the regressing bug 1779952

Assignee: nobody → gwatson
Flags: needinfo?(gwatson)

Pre-cache the clip set -> node information as entries are pushed
on to the clip-tree builder stack.

This page is still not fast (it's a worst case for our current
code with box-shadow clips) but it's better than without this
patch (and we have plans to optimize the box-shadow case).

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/badab985521a
Optimize some of the clip-set building process r=gfx-reviewers,nical
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Blocks: 1782590
QA Whiteboard: [qa-105b-p2]

Reproduced the issue on Firefox 105.0a1 (2022-07-27) under Ubuntu 22.04 by following the STR from Comment 0.

The transition between tabs is slightly better but still a bit hangy (see Comment 2) on Firefox 106.0b9 and Firefox 107.0a1 (2022-10-09). Tests were performed on Ubuntu 22.04, macOS 13 and Windows 11.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-105b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: