Loading icon tab is blank
Categories
(SeaMonkey :: Themes, defect)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: krystian3w, Assigned: frg)
References
(Regression)
Details
Attachments
(3 files)
|
50.98 KB,
image/jpeg
|
Details | |
|
48.69 KB,
image/png
|
Details | |
|
1.64 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
2-49-vs-2-53.jpg (blank incon vs legacy gif)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Firefox/104.0
Steps to reproduce:
Open any tab with lazy page to see blank loading icon
Actual results:
icon does not exists because in css is old gif name: https://gitlab.com/search?search=loading.gif&nav_source=navbar&project_id=14380873&search_code=true&repository_ref=2_53_13_final
Now used is (a)png animation
Expected results:
CSS should be updated to latest name of file
|
Reporter | |
Comment 1•2 years ago
|
||
screen form gitlab with outdated name
|
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Comment 2•2 years ago
|
||
Upps right. But I thought I fixed this before. Didn't notice because running prerelease builds all the time and they have Bug 1296850 in.
|
|
Assignee | |
Comment 3•2 years ago
|
||
If we do a 2.53.13.1 should go in there otherwise can wait till 2.53.14.
[Approval Request Comment]
Regression caused by (bug #): bug 1699322
User impact if declined: no loading indicator
Testing completed (on m-c, etc.): 2.53.14b1 pre (without Bug 1296850 in).
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --
Comment on attachment 9287555 [details] [diff] [review]
1781940-loadingfix-25314.patch
[Triage Comment]
LGTM r/a=me
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/385cb359544a
Use loading.png for showing tab loads. r=IanN
|
|
Assignee | |
Comment 6•2 years ago
|
||
Turns out classic was already fixed in central. I fixed up 1699322-02-gif2png-v1_1-2538.patch for the next 2.53 and only the modern theme fix is/was now needed for both.
|
|
Assignee | |
Comment 7•2 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/98fbb4f048ae03b3e48a67885ef50b279dafc17f
Use loading.png for showing tab loads. r=IanN a=IanN
Description
•