1781962 - swipe-to-navigation is broken on RTL environments

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

there are two problems as of now;

1. The swipe-to-nav icon appears at the opposite side
2. Navigation never happens

The first one will be fixed by D152951, so this bug is for the second one.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

As Timothy pointed out, this is a mixup problem where we can go navigation. In fact we have prefs for swipe-to-nav;

pref("browser.gesture.swipe.left", "Browser:BackOrBackDuplicate");
pref("browser.gesture.swipe.right", "Browser:ForwardOrForwardDuplicate");

Apparently these pref name are problematic. left means here a swipe gesture from left to right, right means a gesture from right to left. On RTL environments it should be swapped.

Comment 2

[Timothy Nikkel (:tnikkel)]

Hmm, how could we properly fix this? I'm not sure.

We could do a little hack that just swaps the actions in RTL browser, I dunno.

Comment 3

[Timothy Nikkel (:tnikkel)]

Maybe the prefs should have the value Browser:HistoryMoveLeft/Right and then browser-gestureSupport.js can convert these to back/forward taking into account rtl?

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1781962. Attempt to navigate in the correct diection when using swipe to nav in RTL. r?hiro

This is a bit of a hack, but a hack that works is better than not working.

Depends on D153845

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1781962 - A simple test case for swipe-to-navigation on RTL. r?tnikkel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5b79baf7a93
Attempt to navigate in the correct diection when using swipe to nav in RTL. r=hiro

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c5b79baf7a93

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c281f844bed5
A simple test case for swipe-to-navigation on RTL. r=tnikkel

Comment 9

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/c281f844bed5

Comment 10

[Monica Chiorean]

Marked as verified on Win10/Win11 using FF build 105.0a1(20220810212956) on AR and HE localizations.