1782025 - Obey contain-intrinsic-size in images

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Oriol Brufau [:Oriol]]

Bug 1780475 already covered images with size containment in a single axis, but images with size containment in both axes are currently ignoring contain-intrinsic-size and just using 0x0.

Note the spec is not completely clear, but what Chromium does seems reasonable:

• Per https://drafts.csswg.org/css-contain/#sizing-as-if-empty, an image with size containment is treated as having no natural aspect ratio, and contain-intrinsic-size doesn't change this.
• An image with size containment is treated as having a natural size of the value provided by contain-intrinsic-size, defaulting to 0x0 for none.

Other approaches can be discussed in https://github.com/w3c/csswg-drafts/issues/7519#issuecomment-1190780627

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1782025 - Obey contain-intrinsic-size in images. r?emilio

Bug 1780475 already covered images with size containment in a single
axis, but images with size containment in both axes were still ignoring
contain-intrinsic-size and just using 0x0.

Note the spec is not completely clear about what to do for replaced
elements with size containment, but what Chromium does seems reasonable:

• No natural aspect ratio, regardless of contain-intrinsic-size.
• Natural sizes are provided by contain-intrinsic-size (0x0 for none).

https://github.com/w3c/csswg-drafts/issues/7519#issuecomment-1190780627
can discuss other approaches, but for now this patch brings consistency
and makes some tests pass.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8baa4dd25fb0
Obey contain-intrinsic-size in images. r=emilio

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/8baa4dd25fb0