Closed Bug 1782029 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35258 - css-shadow-parts: fix ::part() when element also has @exportparts

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35258 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35258
Details from upstream follow.

Delan Azabani <dazabani@igalia.com> wrote:

css-shadow-parts: fix ::part() when element also has @exportparts

CL:3610986 rearranges the loop in StyleResolver::MatchPseudoPartRules
to include the ::part() matching element’s own tree scope, so we can
consider :host::part() rules, but it erroneously maps part names
through @exportparts before moving to the scope directly above. As a
result, we start searching for ::part() rules with our forwarded part
names when we should be searching for rules with our own part names.

This patch defers mapping part names through @exportparts until after
the scope directly above the ::part() matching element.

Fixed: 1347634
Change-Id: Ibe369d0f9324fa9f45112d35d921511513b2b59e
Reviewed-on: https://chromium-review.googlesource.com/3791264
WPT-Export-Revision: 4136cfb27234788086da7590de834586f75de1d2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e466e230edba
[wpt PR 35258] - css-shadow-parts: fix ::part() when element also has @exportparts, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e466e230edba

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.