1782173 - Forward As Attachments. Prohibited symbols interrupt sending (colon in file name?) on Windows

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[clp]

Attachment: error_message.png

Steps to reproduce:

Thunderbird 102.1.0 (64-bit).
Windows 1809 17763.316
mail.ru as email server

You need to have mail in your inbox with this title "МИТАП DevOps: как добиться максимума? Must have инструменты" and my be another (i cant reproduce with other titles) with random or not content.

Next: click right mouse button and select "Forward as" > "Attachment"

In bottom of window you have one Attachment with path "C:\Users\USERNAME\AppData\LocalLow\Mozilla\Temp-{uuid}\pid-PID\МИТАП DevOps: как добиться максимума%3F Must have инструменты.eml"

select To and click Send

Actual results:

Email not sended

Gave error
"""
Unable to save your message as a draft.
There was an error attaching МИТАП DevOps: как добиться максимума? Must have инструменты.eml. Please check that you have access to the file.
"""

File with path "C:\Users\USERNAME\AppData\LocalLow\Mozilla\Temp-{uuid}\pid-PID\МИТАП DevOps: как добиться максимума%3F Must have инструменты.eml" unexist in folder. Only have "МИТАП DevOps"

Expected results:

Email sended

Comment 1

[clp]

Attachment: eml_path.png

Comment 3

[Jens Müller (:tessarakt)]

This can be easily reproduced by sending a mail with subject "???" to oneself, then forwarding as attachment. See bug 1793490.

Comment 4

[clp]

(In reply to Jens Müller (:tessarakt) from comment #3)

This can be easily reproduced by sending a mail with subject "???" to oneself, then forwarding as attachment. See bug 1793490.

Another try with clear mails and

1. subject is "???" - no problem
   attachment stay on server and path to it like "imap-message://MAIL/FOLDER"

2. subject is "МИТАП DevOps: как добиться максимума? Must have инструменты" - problem appears
   attachments path in %APPDATA% folder and ":" in filename not replaced.
   ":" not supported inf ntfs.

Comment 5

[Ping Chen [:rnons] (away)]

Attachment: Bug 1782173 - Fix forwarding msg with special characters in subject. r=mkmelin

Because IOUtils.createUniqueFile doesn't work with colon and other special characters on Windows, use encodeURIComponent when creating tmp file.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c6b706c4dd2f
Fix forwarding msg with special characters in subject. r=mkmelin

Comment 7

[John Bieling (:TbSync)]

Thanks for everybody involved in this bug and getting this fixed!

Should we report this upstream and have the core implementation being fixed?

Comment 8

[John Bieling (:TbSync)]

We use it quite often!
https://searchfox.org/comm-central/search?q=IOUtils.createUniqueFile&path=&case=true&regexp=false

Comment 9

[Magnus Melin [:mkmelin]]

I guess so.

Comment 10

[John Bieling (:TbSync)]

@rnons filed a bug a few days ago already: Bug 1793773

Comment 11

[Ping Chen [:rnons] (away)]

Comment on attachment 9297251 [details]
Bug 1782173 - Fix forwarding msg with special characters in subject. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1760025
User impact if declined: On Windows, can't forward messages containing special characters in the subject
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): no risk, safe to skip beta

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9297251 [details]
Bug 1782173 - Fix forwarding msg with special characters in subject. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.4.0:
https://hg.mozilla.org/releases/comm-esr102/rev/7bf3dc598bd9