1782212 - Enable "curly" eslint rule for self-hosted code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[André Bargull [:anba]]

There isn't (anymore) a clear rule when curly brackets can be omitted in self-hosted code, in some places the styling varies within a single function. Let's add curly brackets everywhere, so we can enable the "curly" eslint rule and because it makes the code more similar to C++ code, where we also require curly brackets everywhere.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 1: Add curly brackets to js/src/builtin/Array.js. r=tcampbell!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 2: Add curly brackets to js/src/builtin/Date.js. r=tcampbell!

Depends on D153172

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 3: Add curly brackets to js/src/builtin/Error.js. r=tcampbell!

Depends on D153173

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 4: Add curly brackets to js/src/builtin/Function.js. r=tcampbell!

Depends on D153174

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 5: Add curly brackets to js/src/builtin/Generator.js. r=tcampbell!

Depends on D153175

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 6: Add curly brackets to js/src/builtin/Iterator.js. r=tcampbell!

Depends on D153176

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 7: Add curly brackets to js/src/builtin/Map.js. r=tcampbell!

Depends on D153177

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 8: Add curly brackets to js/src/builtin/Number.js. r=tcampbell!

Depends on D153178

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 9: Add curly brackets to js/src/builtin/Object.js. r=tcampbell!

Depends on D153179

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 10: Add curly brackets to js/src/builtin/Promise.js. r=tcampbell!

Depends on D153180

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 11: Add curly brackets to js/src/builtin/Reflect.js. r=tcampbell!

Depends on D153181

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 12: Add curly brackets to js/src/builtin/RegExp.js. r=tcampbell!

Depends on D153182

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 13: Add curly brackets to js/src/builtin/RegExp{Global,Local}ReplaceOpt.h.js. r=tcampbell!

Depends on D153183

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 14: Add curly brackets to js/src/builtin/Set.js. r=tcampbell!

Depends on D153184

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 15: Add curly brackets to js/src/builtin/Sorting.js. r=tcampbell!

Depends on D153185

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 16: Add curly brackets to js/src/builtin/String.js. r=tcampbell!

Depends on D153186

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 17: Add curly brackets to js/src/builtin/Tuple.js. r=tcampbell!

Depends on D153187

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 18: Add curly brackets to js/src/builtin/TypedArray.js. r=tcampbell!

Depends on D153188

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 19: Add curly brackets to js/src/builtin/Utilities.js. r=tcampbell!

Depends on D153189

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 20: Add curly brackets to js/src/builtin/Weak{Map,Set}.js. r=tcampbell!

Depends on D153190

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 21: Add curly brackets to js/src/builtin/intl/Collator.js. r=tcampbell!

Depends on D153191

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 22: Add curly brackets to js/src/builtin/intl/CommonFunctions.js. r=tcampbell!

Depends on D153192

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 23: Add curly brackets to js/src/builtin/intl/DateTimeFormat.js. r=tcampbell!

Depends on D153193

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 24: Add curly brackets to js/src/builtin/intl/DisplayNames.js. r=tcampbell!

Depends on D153194

Comment 25

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 25: Add curly brackets to js/src/builtin/intl/ListFormat.js. r=tcampbell!

Depends on D153195

Comment 26

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 26: Add curly brackets to js/src/builtin/intl/NumberFormat.js. r=tcampbell!

Depends on D153196

Comment 27

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 27: Add curly brackets to js/src/builtin/intl/PluralRules.js. r=tcampbell!

Depends on D153197

Comment 28

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 28: Add curly brackets to js/src/builtin/intl/RelativeTimeFormat.js. r=tcampbell!

Depends on D153198

Comment 29

[André Bargull [:anba]]

Attachment: Bug 1782212 - Part 29: Enable eslint 'curly' rule for selfhosted js. r=tcampbell!

Depends on D153199

Comment 30

[Ted Campbell [:tcampbell]]

This is a reasonable thing to standardize. Thanks for cleaning these up.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b331bdbd240e
Part 1: Add curly brackets to js/src/builtin/Array.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/caf30242fabf
Part 2: Add curly brackets to js/src/builtin/Date.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/56c670145cae
Part 3: Add curly brackets to js/src/builtin/Error.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1ac550b468d1
Part 4: Add curly brackets to js/src/builtin/Function.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/df263590d48f
Part 5: Add curly brackets to js/src/builtin/Generator.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/81b94d4664ec
Part 6: Add curly brackets to js/src/builtin/Iterator.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e5d000c3891f
Part 7: Add curly brackets to js/src/builtin/Map.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/316b2c81dd84
Part 8: Add curly brackets to js/src/builtin/Number.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9509f35dd91b
Part 9: Add curly brackets to js/src/builtin/Object.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/846dcd17d480
Part 10: Add curly brackets to js/src/builtin/Promise.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5527faed392b
Part 11: Add curly brackets to js/src/builtin/Reflect.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8162941ed0a0
Part 12: Add curly brackets to js/src/builtin/RegExp.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/be948f4bddea
Part 13: Add curly brackets to js/src/builtin/RegExp{Global,Local}ReplaceOpt.h.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cea4e66816a6
Part 14: Add curly brackets to js/src/builtin/Set.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/775a3ac0e7ea
Part 15: Add curly brackets to js/src/builtin/Sorting.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b1a721e01ab6
Part 16: Add curly brackets to js/src/builtin/String.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/65fe1393de34
Part 17: Add curly brackets to js/src/builtin/Tuple.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/474032d24cfc
Part 18: Add curly brackets to js/src/builtin/TypedArray.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/df7747be627e
Part 19: Add curly brackets to js/src/builtin/Utilities.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/839e3c4c3cd9
Part 20: Add curly brackets to js/src/builtin/Weak{Map,Set}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/3f2394bd8e0b
Part 21: Add curly brackets to js/src/builtin/intl/Collator.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e79ecb3db068
Part 22: Add curly brackets to js/src/builtin/intl/CommonFunctions.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9cfc677b14db
Part 23: Add curly brackets to js/src/builtin/intl/DateTimeFormat.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c5df27312a01
Part 24: Add curly brackets to js/src/builtin/intl/DisplayNames.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4f2d023228d2
Part 25: Add curly brackets to js/src/builtin/intl/ListFormat.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5f9565c4928f
Part 26: Add curly brackets to js/src/builtin/intl/NumberFormat.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d01ff7640164
Part 27: Add curly brackets to js/src/builtin/intl/PluralRules.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6a8d0090dfd3
Part 28: Add curly brackets to js/src/builtin/intl/RelativeTimeFormat.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/30041cc71238
Part 29: Enable eslint 'curly' rule for selfhosted js. r=tcampbell

Comment 32

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b331bdbd240e
https://hg.mozilla.org/mozilla-central/rev/caf30242fabf
https://hg.mozilla.org/mozilla-central/rev/56c670145cae
https://hg.mozilla.org/mozilla-central/rev/1ac550b468d1
https://hg.mozilla.org/mozilla-central/rev/df263590d48f
https://hg.mozilla.org/mozilla-central/rev/81b94d4664ec
https://hg.mozilla.org/mozilla-central/rev/e5d000c3891f
https://hg.mozilla.org/mozilla-central/rev/316b2c81dd84
https://hg.mozilla.org/mozilla-central/rev/9509f35dd91b
https://hg.mozilla.org/mozilla-central/rev/846dcd17d480
https://hg.mozilla.org/mozilla-central/rev/5527faed392b
https://hg.mozilla.org/mozilla-central/rev/8162941ed0a0
https://hg.mozilla.org/mozilla-central/rev/be948f4bddea
https://hg.mozilla.org/mozilla-central/rev/cea4e66816a6
https://hg.mozilla.org/mozilla-central/rev/775a3ac0e7ea
https://hg.mozilla.org/mozilla-central/rev/b1a721e01ab6
https://hg.mozilla.org/mozilla-central/rev/65fe1393de34
https://hg.mozilla.org/mozilla-central/rev/474032d24cfc
https://hg.mozilla.org/mozilla-central/rev/df7747be627e
https://hg.mozilla.org/mozilla-central/rev/839e3c4c3cd9
https://hg.mozilla.org/mozilla-central/rev/3f2394bd8e0b
https://hg.mozilla.org/mozilla-central/rev/e79ecb3db068
https://hg.mozilla.org/mozilla-central/rev/9cfc677b14db
https://hg.mozilla.org/mozilla-central/rev/c5df27312a01
https://hg.mozilla.org/mozilla-central/rev/4f2d023228d2
https://hg.mozilla.org/mozilla-central/rev/5f9565c4928f
https://hg.mozilla.org/mozilla-central/rev/d01ff7640164
https://hg.mozilla.org/mozilla-central/rev/6a8d0090dfd3
https://hg.mozilla.org/mozilla-central/rev/30041cc71238