Closed Bug 1782265 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35273 - [Trusted Types] Ensure internal slot is updated before Node::setTextContent.

Categories

(Core :: DOM: Security, task, P4)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35273 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35273
Details from upstream follow.

Daniel Vogelheim <vogelheim@chromium.org> wrote:

[Trusted Types] Ensure internal slot is updated before Node::setTextContent.

Node::setTextContent may trigger further actions, which in turn may
call ScriptTextInternalSlot(). Ensure that the internal slot is updated
before Node::setTextContent(.) is called, so that a callback to
ScriptTextInternalSlot will see an internally consistent state.

Bug: 1348473
Change-Id: I80b5d08db479da06e79872d60fbcbce514cf7be5
Reviewed-on: https://chromium-review.googlesource.com/3793926
WPT-Export-Revision: 34cdcdf58b15770182b8a390e9e71237255be6f0

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 9 subtests

Status Summary

Firefox

FAIL : 1
ERROR : 2

Chrome

OK : 1
PASS : 57
TIMEOUT: 2
NOTRUN : 7

Safari

FAIL : 1
ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /trusted-types/HTMLElement-generic.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)
  • /trusted-types/HTMLScriptElement-internal-slot.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: ERROR)
    • Test TT application when manipulating <script> elements during loading.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /trusted-types/HTMLElement-generic.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)
  • /trusted-types/HTMLScriptElement-internal-slot.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: ERROR)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38898a6c7464 [wpt PR 35273] - [Trusted Types] Ensure internal slot is updated before Node::setTextContent., a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]

https://hg.mozilla.org/mozilla-central/rev/38898a6c7464

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.