Closed Bug 1782277 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35275 - Implement the :toggle() pseudo-class.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35275 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35275
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Implement the :toggle() pseudo-class.

This implements
https://tabatkins.github.io/css-toggle/#checked-pseudoclass

(Support for toggles is behind the CSSToggles flag, which is currently
off.)

Bug: 1250716
Change-Id: I2d3226c5a023e2bf36dd4d990d57933f932983ce
Reviewed-on: https://chromium-review.googlesource.com/3780614
WPT-Export-Revision: 970efb0a16e9b81cbf195386c454009d8863c55c

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 21 subtests

Status Summary

Firefox

OK : 1
PASS: 3
FAIL: 18

Chrome

OK : 1
PASS: 3
FAIL: 18

Safari

OK : 1
PASS: 3
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-toggle/toggle-pseudo-class.tentative.html [wpt.fyi]
    • ":toggle(my-toggle)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • ":toggle(my-toggle 0)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • ":toggle(my-toggle 1)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • ":toggle( my-toggle 1 )" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • ":toggle(my-toggle named-state)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • ":toggle( my-toggle named-state )" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
    • scope search test for markup
      <div>
      <div class="assert-no-match"></div>
      <div class="toggle assert-match">
      <div class="assert-match"></div>
      </div>
      <div class="assert-match"></div>
      </div>
      <div class="assert-no-match"></div>
      : FAIL (Chrome: FAIL, Safari: FAIL)
    • scope search test for markup
      <div>
      <div class="assert-no-match"></div>
      <div class="toggle-self assert-match">
      <div class="assert-match"></div>
      </div>
      <div class="assert-no-match"></div>
      </div>
      <div class="assert-no-match"></div>
      : FAIL (Chrome: FAIL, Safari: FAIL)
    • scope search test for markup
      <div class="toggle"></div>
      <div class="variant-toggle-self">
      <div class="assert-variant-match"></div>
      </div>
      <div class="assert-match"></div>
      : FAIL (Chrome: FAIL, Safari: FAIL)
    • scope search test for markup
      <div class="toggle"></div>
      <div class="assert-match"></div>
      <div class="variant-toggle">
      <div class="assert-variant-match"></div>
      </div>
      <div class="assert-variant-match"></div>
      : FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle 2 at 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle 2 at 0: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle 2 at named-state: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle [a b c d] at 0: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle [a b c d] at a: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle [a b c d] at 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle [a b c d] at b: FAIL (Chrome: FAIL, Safari: FAIL)
    • :toggle() selector matching tests for my-toggle [a b c d] at unnamed-state: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6081a966cce4
[wpt PR 35275] - Implement the :toggle() pseudo-class., a=testonly
https://hg.mozilla.org/integration/autoland/rev/846aab59e2f4
[wpt PR 35275] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6081a966cce4
https://hg.mozilla.org/mozilla-central/rev/846aab59e2f4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.