1782313 - Fix MCSInfo's shutdown listener to avoid errors if shutdown is already in process when the listener is started.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1766307

Comment 2

[Jens Stutte [:jstutte]]

Hi, I assume you intended to move D152954 here. And I added some comments to the already published patch, would you mind to take a look? Thanks!

Comment 3

[az [:az]]

Attachment: Bug 1782313 - Fix MCSInfo's shutdown listener to avoid errors if shutdown is already in process when the listener is started.

Remove XPCOM shutdown listener from MCSInfo to remove possibility of the listener starting after the shutdown process has already begun.

Comment 4

[az [:az]]

Hi :jstutte, thanks for the heads up + comments! Just wanted to let you know that I read + responded, and will update tomorrow. Thanks!

Comment 5

[az [:az]]

Attachment: Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. r=jstutte

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023fe8af666e
Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. r=media-playback-reviewers,alwu,jrmuizel

Comment 7

[Sandor Molnar[:smolnar]]

Backed out changeset 023fe8af666e (bug 1782313) for causing gtest failures in MediaCodecsSupport

Backout link: https://hg.mozilla.org/integration/autoland/rev/f69ff4d8bbf2dc344dc5ac0a2aab6de7574850c1

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | MediaCodecsSupport.GetMediaCodecsSupportedString | Value of: supportString.Equals( "Codec support information:\nH264 SW\nH264 HW\nVP8 SW"_ns)

Comment 8

[Dianna Smith [:diannaS]]

fixed in 104 by backout of bug 1766307

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox105 (nightly). However, the bug still has low severity.

:jimm, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 10

[az [:az]]

Attachment: Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=alwu,jrmuizel,kinetik

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0ee30333fa0
Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=kinetik,media-playback-reviewers

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d0ee30333fa0