1782337 - Remove unused LineWatcher

Status: RESOLVED FIXED

(Core :: IPC, task, P3)

Description

[Chris Peterson [:cpeterson]]

gcc reports a -Wlogical-op warning about an if statement with duplicate expressions because EAGAIN and EWOULDBLOCK have the same value on some systems (like Linux, Android, and macOS, but not Windows).

However, instead of fixing this -Wlogical-op warning, we can just remove the LineWatcher class because it's unused. It was added for Firefox OS in bug 805478.

ipc/chromium/src/base/message_pump_libevent.cc:422:29: warning: logical 'or' of equal expressions [-Wlogical-op]

        if (errno == EAGAIN || errno == EWOULDBLOCK) {
          return;  // no data available: return and re-poll
        }

https://searchfox.org/mozilla-central/rev/4a15041348e08fb0d6f5726015c32861e663fbfe/ipc/chromium/src/base/message_pump_libevent.cc#422

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1782337 - Remove unused LineWatcher. r?#ipc-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6bd9e91eb46
Remove unused LineWatcher. r=ipc-reviewers,jld

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c6bd9e91eb46