On the "Article not found" error page the "Remove All Expired Articles" button is still missing
Categories
(MailNews Core :: Networking: NNTP, defect)
Tracking
(thunderbird_esr102 fixed, thunderbird104 fixed)
People
(Reporter: infofrommozilla, Assigned: rnons)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
70.85 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details | Review |
13.23 KB,
patch
|
rjl
:
approval-comm-esr102+
|
Details | Diff | Splinter Review |
Bug 1778229 has brought the page back, but the button to remove the expired items is still missing.
Reporter | ||
Comment 1•3 years ago
|
||
It's this button:
https://searchfox.org/comm-central/rev/18c2ea0afb88b6abbeb8429861f3eac9e7a2ec35/mailnews/base/content/newsError.xhtml#48
According to the inspector, the button is only set to hidden.
The cause of this lies here:
if ("f" in params) {
folderUri = params.f;
} else {
document.getElementById("errorTryAgain").hidden = true;
}
params
content:
k: "201"
m: "tc3m2t.8bk.1@gammasigma.xy"
r: "no such article number in this group"
<prototype>: {…}
Indeed, no f
Assignee | ||
Comment 2•3 years ago
|
||
Thanks, this needs some more work than showing the button. I though ?list-ids
was unused, will support it.
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d592397ca1fd
Support removing all expired NNTP articles. r=mkmelin
Reporter | ||
Comment 5•3 years ago
|
||
Works fine in TB105.0a1.
Thaks for fixing it.
Should we lift this up like we did Bug 1778229?
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9288213 [details]
Bug 1782365 - Support removing all expired NNTP articles. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Can't remove all expired NNTP articles by clicking a button on newsError.xhtml
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low
Comment 7•3 years ago
|
||
Comment on attachment 9288213 [details]
Bug 1782365 - Support removing all expired NNTP articles. r=mkmelin
[Triage Comment]
Approved for beta
Comment 8•3 years ago
|
||
This doesn't uplift to beta without bug 1781720. If we want it on c-esr102, it will need a new patch anyway.
Assignee | ||
Comment 9•2 years ago
|
||
Will request for esr102 directly after 105, thanks.
Comment 10•2 years ago
|
||
bugherder uplift |
Thunderbird 104.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/356573a42066
Comment 11•2 years ago
|
||
I'm currently on 102.1.2 (64-bit) on Windows 10.
What can I need to do to consume this fix?
a) wait until automatic update
b) install the following stable version ...
c) exchange file ... on OS with ...
Thank you in advance.
Assignee | ||
Comment 12•2 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Can't remove all expired NNTP articles by clicking a button on newsError.xhtml
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low
Comment 13•2 years ago
|
||
Comment on attachment 9291025 [details] [diff] [review]
1782365-esr102.patch
[Triage Comment]
Approved for esr102
Comment 14•2 years ago
|
||
Comment 15•2 years ago
|
||
[Triage Comment]
Updated esr102 patch with missing _logger in NntpChannel. Setting to approved based on prior approval for c-esr102.
Comment 16•2 years ago
|
||
bugherder uplift |
Thunderbird 102.2.1:
https://hg.mozilla.org/releases/comm-esr102/rev/c52742d308b7
Description
•