Closed Bug 1782443 Opened 3 years ago Closed 3 years ago

DrawTargetWebgl::LockBits doesn't call MarkSkiaChanged

Categories

(Core :: Graphics: Canvas2D, defect)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DrawTargetWebgl::LockBits doesn't call MarkSkiaChanged before accessing the Skia context, so its contents are not accurate. This causes the bug pointed out in bug 1781776 comment 2:

Since the mentioned regression, this canvas-based game doesn't show anything on the screen. It otherwise works fine (press X to hear a sound effect when the game starts).
https://clementsparrow.github.io/Pattern-Script/src/play.html?p=6841219

Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dce608b43d96 Call MarkSkiaChanged in DrawTargetWebgl::LockBits. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: