[wpt-sync] Sync PR 35289 - Fix Aho-Corasick trees with attribute existence selectors.
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 35289 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/35289
Details from upstream follow.
Steinar H. Gunderson <sesse@chromium.org> wrote:
Fix Aho-Corasick trees with attribute existence selectors.
The Aho-Corasick code to accelerate large number of attribute selectors
has special provisions for empty attributes, i.e., [attr=""]. However,
we did not take into account that [attr] also is counted as having an
empty value (and that one could theoretically also have things like
[attr*=""], to the same effect). This would cause us to mistakenly
skip [attr] rules when the element had attr="\<anything nonempty>"
and the Aho-Corasick tree was active (ie., we had more then 50 rules
for attr).Fixed: 1345818, 1346804, 1343300
Bug: 1318773
Change-Id: I9fd174edc3b870eb624bf632d1b996e04403b73eReviewed-on: https://chromium-review.googlesource.com/3802826
WPT-Export-Revision: 738c39faf631d70e356779ec0a533c3effc547e2
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=525eb35b801107b31106653f4adc403dbc44dd58
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29f3728c1d84 [wpt PR 35289] - Fix Aho-Corasick trees with attribute existence selectors., a=testonly
Description
•