1782535 - Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P1)

Description

[Dimi Lee [:dimi]]

From data we've collected so far (nightly and beta), we haven't seen significant improvement after landing Bug 1775233, instead, the percentage of times users fill a credit card form when a popup is shown decreases.

So we should only enable this feature in nightly and beta for now and re-enable this feature once we improve the accuracy of credit card fathom model.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1782535 - P1. Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta r=sgalich

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1782535 - P2. Update testcase r=sgalich

Depends on D153581

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/152753c29e75
P1. Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta r=sgalich
https://hg.mozilla.org/integration/autoland/rev/85b8385dff44
P2. Update testcase r=sgalich

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/152753c29e75
https://hg.mozilla.org/mozilla-central/rev/85b8385dff44

Comment 5

[Dimi Lee [:dimi]]

Comment on attachment 9288277 [details]
Bug 1782535 - P1. Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta r=sgalich

Beta/Release Uplift Approval Request

• User impact if declined: For users with credit card saved in Firefox, they might see credit card autocomplete dropdown in non-credit card input fields
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch simply reverts the change made in Bug 1775233 (for release build).
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9288277 [details]
Bug 1782535 - P1. Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta r=sgalich

Approved for 104.0b6

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9db2c017db3
https://hg.mozilla.org/releases/mozilla-beta/rev/a4a431541b1d