Closed Bug 1782584 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35293 - ContainingFragmentationContextRoot() for column spanners

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35293 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35293
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

ContainingFragmentationContextRoot() for column spanners

In CL:3343283, when an OOF was contained within a column spanner, we
would lay out the OOF in the fragmentation context root above, if there
was one (given that spanners don't participate in the fragmentation
context root of the nearest context).

If an OOF was nested in an abpos multicol inside a column spanner, we
would hit NOTREACHED() in NGOutOfFlowLayoutPart::ReplaceFragment(),
because the fragments of the abspos multicol were not found in the
nearest fragmentation context root ancestor, but rather in the next
above.

To fix this, update ContainingFragmentationContextRoot() to retrieve
the correct fragmentation context root in the case of a column
spanner.

Bug: 1348128
Change-Id: Ica05a41b23cade26c93a18cfd80eaa167ed2863e
Reviewed-on: https://chromium-review.googlesource.com/3795714
WPT-Export-Revision: 88c30a4449b19bf3f7de6ef2bc0dce7d02f41ae1

Component: web-platform-tests → Layout
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2fac14f3774
[wpt PR 35293] - ContainingFragmentationContextRoot() for column spanners, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.