1782595 - [css-mediaqueries] propagate preferred color-scheme into SVG images, when embedding context has color-scheme: normal and no color-scheme meta tag

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mozilla Apprentice]

Resolutions were made for csswg-drafts/#7526.

[css-mediaqueries] Clarify propagated preferred color-scheme on SVG images with color-scheme: normal and no color-scheme meta tag

• RESOLVED: do what Emilio said
• RESOLVED: for the purposes of propagating prefers-color-scheme to the embedded page, if `color-scheme` is `normal` and there's no `color-scheme` meta tag, the propagated scheme is the preferred color-scheme of the embedder document

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

emilio, I'm guessing you might want to take this, since it was your proposal and it's probably a small change?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: We should fix this for 104 to avoid shipping the wrong behavior to the web, or pref off to keep the 103 behavior. The change is trivial tho.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox104 (beta). However, the bug still has low severity.

:fgriffith, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I disabled this on beta to get a bit more time: https://bugzilla.mozilla.org/show_bug.cgi?id=1779457#c10

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782595 - Distinguish between "preferred" and "used" color-scheme. r=dholbert,aosmond,tnikkel,#layout

The "preferred" one is the behavior we have for chrome docs, where we
fall back always to the document's preferred color-scheme rather than
falling back to light.

We'll use this in the next patch.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782595 - Use the preferred color-scheme to propagate to SVG images. r=dholbert,aosmond,tnikkel,#layout

We have tests for the explicit color-scheme in the WPT, and testing this
properly needs prefs to switch the light/dark preference so tests can't
go there.

Undoing https://hg.mozilla.org/integration/autoland/rev/f31efc2a9229
should be enough to cover the difference between preferred and used
color-scheme.

Depends on D154923

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94d84d49dba2
Distinguish between "preferred" and "used" color-scheme. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/9d677ac57528
Use the preferred color-scheme to propagate to SVG images. r=tnikkel

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/94d84d49dba2
https://hg.mozilla.org/mozilla-central/rev/9d677ac57528