Closed Bug 1782613 Opened 2 years ago Closed 2 years ago

Use more asserts for self-hosted built-ins

Categories

(Core :: JavaScript Engine, task, P2)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1782613 - Assert correct arguments for more self-hosted built-ins. r?arai
48 bytes, text/x-phabricator-request
Details | Review

(In reply to Mathew Hodson from comment #5)

What about the two remaining uses of ensureArgs in BytecodeEmitter.cpp? Should those be turned into asserts as well?

(In reply to Tooru Fujisawa [:arai] from comment #6)

Those 2 are debug-only functions and doesn't affect the release build, so not much priority.
But yeah, it would be nice to fix in followup bug.

Depends on: 1481695

Remove some now unused debug error checking code.

Assignee: nobody → mathew.hodson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Blocks: sm-meta
Severity: -- → N/A
Priority: -- → P2
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/5c61844b966a
Assert correct arguments for more self-hosted built-ins. r=arai

https://hg.mozilla.org/mozilla-central/rev/5c61844b966a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: