1782672 - Debugger UI crash when using closeAllTabs on a minified file with an error

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open https://debugger-crash-close-all-tabs.glitch.me/
• open debugger
• select minified.js
• right click on source tab
• choose close all tabs

ER: should close tabs
AR: Debugger UI crashes

Stack trace:

clearEditorExceptionLine@resource://devtools/client/debugger/src/components/Editor/Exception.js:95:7
componentWillUnmount@resource://devtools/client/debugger/src/components/Editor/Exception.js:46:10
callComponentWillUnmountWithTimer@resource://devtools/client/shared/vendor/react-dom.js:12816:12
safelyCallComponentWillUnmount@resource://devtools/client/shared/vendor/react-dom.js:12824:40
commitUnmount@resource://devtools/client/shared/vendor/react-dom.js:13147:41
commitNestedUnmounts@resource://devtools/client/shared/vendor/react-dom.js:13178:18
unmountHostComponents@resource://devtools/client/shared/vendor/react-dom.js:13439:27
commitDeletion@resource://devtools/client/shared/vendor/react-dom.js:13498:26
commitAllHostEffects@resource://devtools/client/shared/vendor/react-dom.js:14142:25
commitRoot@resource://devtools/client/shared/vendor/react-dom.js:14344:9
completeRoot/<@resource://devtools/client/shared/vendor/react-dom.js:15731:15
unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12
completeRoot@resource://devtools/client/shared/vendor/react-dom.js:15730:27
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15659:21
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:39:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:35:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
closeTabs/<@resource://devtools/client/debugger/src/actions/tabs.js:82:13

Comment 1

[Hubert Boma Manilla (:bomsy)]

Nice catch.
It looks like the codemirror has already been destroyed at the point where we try to unmount the exception component.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1782672 - [devtools] Make sure codemirror document still exists during component update/unmount r=jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdaf86976015
[devtools] Make sure codemirror document still exists during component update/unmount r=jdescottes

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bdaf86976015

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue using an affected build from 2022-08-02 on Windows 10.
Verified as fixed on Firefox 106.0 (20221010110315) on Win 10, Ubuntu 2104 and macOS 10.15.