1782673 - Obey contain-intrinsic-size in iframes

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Oriol Brufau [:Oriol]]

nsSubDocumentFrame.cpp assumes a 0px intrinsic size when there is size containment.
Instead it should use the size resulting from contain-intrinsic-size.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1782673 - Obey contain-intrinsic-size in iframes. r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b80c6cb760
Obey contain-intrinsic-size in iframes. r=emilio

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/64b80c6cb760

Comment 5

[Oriol Brufau [:Oriol]]

Who are these "wpt sync admins" that can solve the situation from comment 3?
The problem was that patch here was on top of bug 1782589, which landed first, but the sync bot tried to export in the opposite order.

Comment 6

[Oriol Brufau [:Oriol]]

Will the wptsync bot get further confused if I export the changes manually? https://github.com/web-platform-tests/wpt/pull/35400

Comment 7

[Oriol Brufau [:Oriol]]

I'm awaiting for this before landing bug 1783296 since it alters the affected test.
Should I land bug 1783296 anyways?
Should I export manually? Please review https://github.com/web-platform-tests/wpt/pull/35400

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Yeah, James is probably on PTO. I've merged that manually for now, so that should unblock you. Probably we just need to close the wptsync PR at this point but I'll let James confirm.

Comment 9

[James Graham [:jgraham]]

OK, I think I dealt with this merge conflict when handling the sync, but it would be great if you could verify that m-c is now in the state that you expect.

Comment 10

[Oriol Brufau [:Oriol]]

Seems good.

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36039 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham